Skip to content

Commit a0522b9

Browse files
committed
Fix trailing whitespace and use saturating arithmetic in tests
- Remove trailing whitespace in lib.rs (cargo fmt) - Replace bare `-` operators with `.saturating_sub()` for I32F32 diff calculations in consensus_mode tests - Replace `u16::MAX / 2` with `u16::MAX.saturating_div(2)`
1 parent 958be6e commit a0522b9

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

pallets/subtensor/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1877,12 +1877,12 @@ pub mod pallet {
18771877
#[pallet::storage]
18781878
pub type AlphaValues<T> =
18791879
StorageMap<_, Identity, NetUid, (u16, u16), ValueQuery, DefaultAlphaValues<T>>;
1880-
1880+
18811881
/// MAP ( netuid ) --> consensus mode for liquid alpha calculation
18821882
#[pallet::storage]
18831883
pub type LiquidAlphaConsensusMode<T> =
18841884
StorageMap<_, Identity, NetUid, ConsensusMode, ValueQuery, DefaultConsensusMode<T>>;
1885-
1885+
18861886
/// --- MAP ( netuid ) --> If subtoken trading enabled
18871887
#[pallet::storage]
18881888
pub type SubtokenEnabled<T> =

pallets/subtensor/src/tests/consensus_mode.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,9 @@ fn test_compute_consensus_previous_mode() {
212212
let expected = I32F32::from_num(prev);
213213
// Allow small floating point difference
214214
let diff = if *res > expected {
215-
*res - expected
215+
res.saturating_sub(expected)
216216
} else {
217-
expected - *res
217+
expected.saturating_sub(*res)
218218
};
219219
assert!(
220220
diff < I32F32::from_num(0.001),
@@ -237,7 +237,7 @@ fn test_compute_consensus_auto_mode() {
237237
let (current_consensus, previous_values) = create_test_consensus_data(netuid);
238238

239239
// Test 1: bond_penalty != 1, should use Current
240-
SubtensorModule::set_bonds_penalty(netuid, u16::MAX / 2); // 0.5
240+
SubtensorModule::set_bonds_penalty(netuid, u16::MAX.saturating_div(2)); // 0.5
241241
let result =
242242
SubtensorModule::compute_consensus_for_liquid_alpha(netuid, &current_consensus);
243243

@@ -258,9 +258,9 @@ fn test_compute_consensus_auto_mode() {
258258
for (res, &prev) in result.iter().zip(previous_values.iter()) {
259259
let expected = I32F32::from_num(prev);
260260
let diff = if *res > expected {
261-
*res - expected
261+
res.saturating_sub(expected)
262262
} else {
263-
expected - *res
263+
expected.saturating_sub(*res)
264264
};
265265
assert!(
266266
diff < I32F32::from_num(0.001),

0 commit comments

Comments
 (0)