Updating an image tag in a values.yaml removes indentation on some comments, too?

[kastl-ars]

Dear all,

I am currently trying to get the helm chart guide running. I have a manifest that is working locally.

However I noticed that the update of the image tag in the values.yaml file also changes the indentation on some commented example code. Which it should not do in my opinion, as the indentation was intentionally by the chart authors to imply that the commented lines are children of the non-commented line before.

Before:

securityContext: {}
  # capabilities:
  #   drop:
  #   - ALL
  # readOnlyRootFilesystem: true
  # runAsNonRoot: true
  # runAsUser: 1000

After (hashmarks aligned with securityContext):

securityContext: {}
# capabilities:
#   drop:
#   - ALL
# readOnlyRootFilesystem: true
# runAsNonRoot: true
# runAsUser: 1000

An example commit is here

Can I tell updatecli to not "fix" indentations in the yaml files and only replace the one line?

Kind Regards,
Johannes

[olblak]

Hi Joannes,

Unfortunately it's not possible. On the Updatecli project we rely on two different YAML parser:

• https://github.com/goccy/go-yaml
• https://github.com/yaml/go-yaml V3

I just tested using

targets:
  yaml:
    kind: yaml
    spec:
      file: "values.yaml"
      engine: yamlpath
      key: "version"
      value: "2.0.0"

and it modified the comment as you noticed.

Both parser have strenghts and weaknesses which is why we allow to pick one.
Right now only the plugin yaml allow to select the engine using the parameter engine