Skip to content

Commit bb8eb7f

Browse files
committed
Fix CSS BEM naming violations
1 parent b07fc88 commit bb8eb7f

2 files changed

Lines changed: 28 additions & 16 deletions

File tree

src/components/InstructionsEditor.jsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,25 @@ export default class InstructionsEditor extends React.Component {
2626
render() {
2727
return (
2828
<div className="instructions-editor">
29-
<div className="instructions-editor-menu">
30-
<button onClick={this._handleSaveChanges}>
29+
<div className="instructions-editor__menu">
30+
<button
31+
className="instructions-editor__menu-button"
32+
onClick={this._handleSaveChanges}
33+
>
3134
{t('workspace.components.instructions.save')}
3235
</button>
33-
<button onClick={this._handleCancelEditing}>
36+
<button
37+
className="instructions-editor__menu-button"
38+
onClick={this._handleCancelEditing}
39+
>
3440
{t('workspace.components.instructions.cancel')}
3541
</button>
3642
</div>
37-
<pre contentEditable ref={this._ref}>
43+
<pre
44+
contentEditable
45+
className="instructions-editor__input"
46+
ref={this._ref}
47+
>
3848
{this.state.instructions}
3949
</pre>
4050
</div>

src/css/application.css

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -342,32 +342,34 @@ body {
342342
}
343343
}
344344

345+
/** @define instructions-editor */
346+
345347
.instructions-editor {
346348
height: 100%;
347349
padding-top: calc(28px + 1rem);
350+
}
348351

349-
& pre {
350-
height: 100%;
351-
margin: 0;
352-
outline: 0;
353-
word-wrap: break-word;
354-
white-space: pre-wrap;
355-
}
352+
.instructions-editor__input {
353+
height: 100%;
354+
margin: 0;
355+
outline: 0;
356+
word-wrap: break-word;
357+
white-space: pre-wrap;
356358
}
357359

358-
.instructions-editor-menu {
360+
.instructions-editor__menu {
359361
position: absolute;
360362
top: 0;
361363
right: 0;
362364
left: 0;
363-
padding: .5rem;
365+
padding: 0.5rem;
364366
margin-bottom: 100%;
365367
text-align: right;
366368
background-color: var(--color-light-gray);
369+
}
367370

368-
& button:not(:last-child) {
369-
margin-right: .5em;
370-
}
371+
.instructions-editor__menu-button:not(:last-child) {
372+
margin-right: 0.5em;
371373
}
372374

373375
/** @define project-preview */

0 commit comments

Comments
 (0)