From 1c429cc2bda5efcc3cb1a92e1eea178c6a255376 Mon Sep 17 00:00:00 2001 From: Mrinal Karvir Date: Mon, 1 Jun 2026 22:33:58 +0000 Subject: [PATCH 1/2] installer: split required vs optional binaries Closes the install regression where a missing rocm-codex binary in the release tarball caused install.sh to abort before placing anything in INSTALL_DIR. rocm and rocmd are now required; rocm-codex and engine plugins are optional and emit a warning when missing. --- install.sh | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/install.sh b/install.sh index 589b717d..fc49ca78 100755 --- a/install.sh +++ b/install.sh @@ -224,10 +224,21 @@ tar -xzf "$archive_path" -C "$extract_dir" bundle_dir="$(find "$extract_dir" -mindepth 1 -maxdepth 1 -type d | head -n1)" [ -n "$bundle_dir" ] || fail "unable to locate extracted bundle directory" -[ -f "${bundle_dir}/bin/rocm" ] || fail "bundle did not contain bin/rocm" -[ -f "${bundle_dir}/bin/rocmd" ] || fail "bundle did not contain bin/rocmd" -[ -f "${bundle_dir}/bin/rocm-engine-pytorch" ] || fail "bundle did not contain bin/rocm-engine-pytorch" -[ -f "${bundle_dir}/bin/rocm-codex" ] || fail "bundle did not contain bin/rocm-codex" +# Required binaries — the CLI cannot function without these. +REQUIRED_BINS="rocm rocmd" +# Optional binaries — desirable but not load-bearing. Missing ones produce a +# warning so the install succeeds with reduced functionality rather than +# failing entirely (e.g. a release bundle missing rocm-codex should still +# install the working CLI). +OPTIONAL_BINS="rocm-engine-pytorch rocm-codex" + +for bin_name in $REQUIRED_BINS; do + [ -f "${bundle_dir}/bin/${bin_name}" ] || fail "bundle did not contain required binary bin/${bin_name}" +done + +for bin_name in $OPTIONAL_BINS; do + [ -f "${bundle_dir}/bin/${bin_name}" ] || echo "rocm-cli installer: warning: bundle missing optional binary bin/${bin_name}" >&2 +done mkdir -p "$INSTALL_DIR" From 744260a342f7de9fee09b07486c82a05283265f7 Mon Sep 17 00:00:00 2001 From: amd-mkarvir Date: Mon, 1 Jun 2026 18:10:26 -0700 Subject: [PATCH 2/2] docs: clarify rocm-codex is optional in repo status --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 208ab033..7c621614 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ Current repository status: - `rocmd` supervisor with managed service supervision and persisted automation/watcher runtime state - first-party `pytorch` engine with managed venv installs, TheRock PyTorch wheel resolution, and OpenAI-compatible local serving - TheRock SDK resolver for `pip` and tarball installs, plus managed runtime update checks -- vendored Codex TUI scaffold with a packaged `rocm-codex` binary for experimental interactive launch +- vendored Codex TUI scaffold launched via `rocm --experimental-codex-tui` when the optional `rocm-codex` binary is present Planned product shape: - `rocm` chat-first TUI with deeper inline tool execution and approvals