Mobkoi: Always set TagId with placementId (#4435)

Author: osulzhenko

src/main/java/org/prebid/server/bidder/mobkoi/MobkoiBidder.java

@@ -75,14 +75,14 @@ private ExtImpMobkoi parseExtImp(Imp imp) {
     }
 
     private Imp modifyImp(Imp firstImp, ExtImpMobkoi extImpMobkoi) {
-        if (StringUtils.isNotBlank(firstImp.getTagid())) {
-            return firstImp;
-        }
-
         if (StringUtils.isNotBlank(extImpMobkoi.getPlacementId())) {
             return firstImp.toBuilder().tagid(extImpMobkoi.getPlacementId()).build();
         }
 
+        if (StringUtils.isNotBlank(firstImp.getTagid())) {
+            return firstImp;
+        }
+
         throw new PreBidException("invalid because it comes with neither request.imp[0].tagId nor "
                     + "req.imp[0].ext.Bidder.placementId");
     }

src/test/java/org/prebid/server/bidder/mobkoi/MobkoiBidderTest.java

@@ -91,10 +91,46 @@ public void makeHttpRequestsShouldAddPlacementIdOnlyInFirstImpressionTagId() {
         assertThat(result.getValue())
                 .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class))
                 .flatExtracting(BidRequest::getImp)
-                .extracting(imp -> imp.getTagid())
+                .extracting(Imp::getTagid)
                 .containsExactly("pid", null);
     }
 
+    @Test
+    public void makeHttpRequestsShouldOverrideTagIdWithPlacementId() {
+        // given
+        final ObjectNode mobkoiExt = impExt("pid");
+        final Imp givenImp = givenImp(impBuilder -> impBuilder.tagid("tagId").ext(mobkoiExt));
+        final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp)).build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue())
+                .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class))
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getTagid)
+                .containsExactly("pid");
+    }
+
+    @Test
+    public void makeHttpRequestsShouldKeepOriginalTagIdWhenPlacementIdMissing() {
+        // given
+        final ObjectNode mobkoiExt = impExt(null);
+        final Imp givenImp = givenImp(impBuilder -> impBuilder.tagid("tagId").ext(mobkoiExt));
+        final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp)).build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue())
+                .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class))
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getTagid)
+                .containsExactly("tagId");
+    }
+
     @Test
     public void makeHttpRequestsShouldOverrideUserExtAndSetConsent() {
         // given