From 32381479a271fc5508b7043648b1853b00a2c8b7 Mon Sep 17 00:00:00 2001 From: Ethan Byrd Date: Sat, 18 Jul 2026 12:48:08 -0700 Subject: [PATCH 1/2] Bump the docfacts impact pin past the packages/ restructure The pinned revision predates a restructure that moved the CLI entry path, so the impact check failed with ERR_MODULE_NOT_FOUND on every PR. The new revision uses the current entry path, pins its own checkout to the same SHA so the workflow and the engine it runs move together, and makes the compute step continue-on-error so tool breakage cannot fail a PR (the check is report-only). --- .github/workflows/docfacts-impact.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docfacts-impact.yml b/.github/workflows/docfacts-impact.yml index 73d967ef..5a88973d 100644 --- a/.github/workflows/docfacts-impact.yml +++ b/.github/workflows/docfacts-impact.yml @@ -9,7 +9,7 @@ permissions: contents: read jobs: impact: - uses: primitivedotdev/docfacts/.github/workflows/impact.yml@42413cfcb2d9ff116f60ba34d48b5843cc9e83a8 # pin: docfacts main; bump deliberately + uses: primitivedotdev/docfacts/.github/workflows/impact.yml@0a45f0bbd17a93cc40a42159737cf11c4c2a84cf # pin: docfacts main; bump deliberately with: repo_key: sdks secrets: From ed6f19712fc89641e65ed586bc0968977f3120b0 Mon Sep 17 00:00:00 2001 From: Ethan Byrd Date: Sat, 18 Jul 2026 13:40:56 -0700 Subject: [PATCH 2/2] Pin the engine ref alongside the workflow The first pin's revision derived the engine checkout from github.workflow_sha, which inside a called reusable workflow resolves in the CALLER's context, so it pointed at a commit that does not exist in the tool's repo and the checkout failed. Repin to the revision that takes the ref as an explicit input and pass the same SHA for both, so the workflow file and the engine it runs stay on one commit. That revision also makes the whole job continue-on-error, so a failure in any step there cannot fail a PR here. --- .github/workflows/docfacts-impact.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/docfacts-impact.yml b/.github/workflows/docfacts-impact.yml index 5a88973d..70d5fd3e 100644 --- a/.github/workflows/docfacts-impact.yml +++ b/.github/workflows/docfacts-impact.yml @@ -9,8 +9,9 @@ permissions: contents: read jobs: impact: - uses: primitivedotdev/docfacts/.github/workflows/impact.yml@0a45f0bbd17a93cc40a42159737cf11c4c2a84cf # pin: docfacts main; bump deliberately + uses: primitivedotdev/docfacts/.github/workflows/impact.yml@ca881c2f19e84c9f977478b6f405b342d3171de4 # pin: docfacts main; bump deliberately with: repo_key: sdks + docfacts_ref: ca881c2f19e84c9f977478b6f405b342d3171de4 secrets: docfacts_read_token: ${{ secrets.DOCFACTS_READ_TOKEN }}