Skip to content

Remove orphaned dependencies#14

Merged
savetheclocktower merged 1 commit into
masterfrom
remove-orphaned-deps
May 24, 2026
Merged

Remove orphaned dependencies#14
savetheclocktower merged 1 commit into
masterfrom
remove-orphaned-deps

Conversation

@confused-Techie
Copy link
Copy Markdown
Member

While attempting to find where we still used emissary here (to attempt to remove es5-ext), I discovered that we actually don't.

Even more there was a surprising amount of dependencies in this repo that we just flat out don't use.

Copy link
Copy Markdown

@savetheclocktower savetheclocktower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following up with some archaeology.

First the devDependencies:

  • cpy-cli used to be part of the build process.
  • json-diff was used in the specs optionally — there were some lines you could uncomment for more debugging information if a spec failed.
  • standard was used for linting instead of ESLint. (I imagine we got rid of linting when we decaffeinated this package, which is fine. We can reinstate it later if we want to.)

And now the dependencies:

  • emissary was once used for events instead of event-kit. I imagine it just didn't get removed when Atom migrated to event-kit.
  • serializable was once used for… well, serialization. I can only guess that the move to superstring removed most references to serializable.

At any rate: these definitely aren't used anymore, so they're safe to remove even if we didn't understand why they were added in the first place!

@savetheclocktower savetheclocktower merged commit 78b7f03 into master May 24, 2026
2 checks passed
@savetheclocktower savetheclocktower deleted the remove-orphaned-deps branch May 24, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants