Remove orphaned dependencies#14
Merged
Merged
Conversation
savetheclocktower
approved these changes
May 24, 2026
savetheclocktower
left a comment
There was a problem hiding this comment.
Just following up with some archaeology.
First the devDependencies:
cpy-cliused to be part of the build process.json-diffwas used in the specs optionally — there were some lines you could uncomment for more debugging information if a spec failed.standardwas used for linting instead of ESLint. (I imagine we got rid of linting when we decaffeinated this package, which is fine. We can reinstate it later if we want to.)
And now the dependencies:
emissarywas once used for events instead ofevent-kit. I imagine it just didn't get removed when Atom migrated toevent-kit.serializablewas once used for… well, serialization. I can only guess that the move tosuperstringremoved most references toserializable.
At any rate: these definitely aren't used anymore, so they're safe to remove even if we didn't understand why they were added in the first place!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to find where we still used
emissaryhere (to attempt to removees5-ext), I discovered that we actually don't.Even more there was a surprising amount of dependencies in this repo that we just flat out don't use.