From 9d134ec05c3360a05dc1ca3cb35a8df75b64ff5e Mon Sep 17 00:00:00 2001 From: Christoph Langer Date: Sun, 9 Aug 2026 10:37:48 +0200 Subject: [PATCH 1/2] Add a test fixture for testing incoming transfer without eventType field Makes sure the issue of #350 does not reoccur --- ...ties_transfer_incoming_null_eventType.json | 83 +++++++++++++++++++ tests/test_events.py | 18 ++++ 2 files changed, 101 insertions(+) create mode 100644 tests/events/securities_transfer_incoming_null_eventType.json diff --git a/tests/events/securities_transfer_incoming_null_eventType.json b/tests/events/securities_transfer_incoming_null_eventType.json new file mode 100644 index 0000000..96124da --- /dev/null +++ b/tests/events/securities_transfer_incoming_null_eventType.json @@ -0,0 +1,83 @@ +{ + "id": "756ce232-a67d-4d85-a431-57483426450a", + "timestamp": "2025-10-13T12:43:03.988+0000", + "title": "MSCI EM USD (Acc)", + "icon": "logos/IE00BTJRMP35/v2", + "subtitle": "Aktien erhalten", + "action": { + "type": "timelineDetail", + "payload": "756ce232-a67d-4d85-a431-57483426450a" + }, + "cashAccountNumber": "123456789", + "eventType": null, + "hidden": false, + "deleted": false, + "source": "timelineActivity", + "details": { + "id": "756ce232-a67d-4d85-a431-57483426450a", + "sections": [ + { + "type": "header", + "title": "You received 7 shares", + "data": { + "status": "executed", + "icon": "logos/IE00BTJRMP35/v2", + "timestamp": "2025-10-13T12:43:03.988647Z" + } + }, + { + "type": "table", + "title": "Overview", + "data": [ + { + "title": "Status", + "style": "plain", + "detail": { + "type": "status", + "text": "Completed", + "functionalStyle": "EXECUTED" + } + }, + { + "title": "Asset", + "style": "plain", + "detail": { + "type": "text", + "text": "MSCI EM USD (Acc)" + } + }, + { + "title": "Action", + "style": "plain", + "detail": { + "type": "text", + "text": "Securities transfer" + } + } + ] + }, + { + "type": "table", + "title": "Transaction", + "data": [ + { + "title": "Shares", + "style": "plain", + "detail": { + "type": "text", + "text": "7" + } + }, + { + "title": "Fee", + "style": "plain", + "detail": { + "type": "text", + "text": "Free" + } + } + ] + } + ] + } +} diff --git a/tests/test_events.py b/tests/test_events.py index 13d8796..80e8cb6 100644 --- a/tests/test_events.py +++ b/tests/test_events.py @@ -1773,6 +1773,24 @@ } ], }, + { + "filename": "securities_transfer_incoming_null_eventType.json", + "event_type": PPEventType.TRANSFER_IN, + "title": "MSCI EM USD (Acc)", + "isin": "IE00BTJRMP35", + "shares": 7, + "value": 0, + "transactions": [ + { + "Datum": "2025-10-13T12:43:03", + "Typ": "Umbuchung (Eingang)", + "Wert": 0, + "Notiz": "MSCI EM USD (Acc)", + "ISIN": "IE00BTJRMP35", + "Stück": 7.0, + } + ], + }, { "filename": "sell_stop.json", "event_type": ConditionalEventType.TRADE_INVOICE, From 499cb9fc7b09c42a3eadd3357d92f8f598c34a1c Mon Sep 17 00:00:00 2001 From: Christoph Langer Date: Sun, 9 Aug 2026 10:41:15 +0200 Subject: [PATCH 2/2] no eventType instead of null eventType --- ...Type.json => securities_transfer_incoming_no_eventType.json} | 1 - tests/test_events.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) rename tests/events/{securities_transfer_incoming_null_eventType.json => securities_transfer_incoming_no_eventType.json} (98%) diff --git a/tests/events/securities_transfer_incoming_null_eventType.json b/tests/events/securities_transfer_incoming_no_eventType.json similarity index 98% rename from tests/events/securities_transfer_incoming_null_eventType.json rename to tests/events/securities_transfer_incoming_no_eventType.json index 96124da..05f4e29 100644 --- a/tests/events/securities_transfer_incoming_null_eventType.json +++ b/tests/events/securities_transfer_incoming_no_eventType.json @@ -9,7 +9,6 @@ "payload": "756ce232-a67d-4d85-a431-57483426450a" }, "cashAccountNumber": "123456789", - "eventType": null, "hidden": false, "deleted": false, "source": "timelineActivity", diff --git a/tests/test_events.py b/tests/test_events.py index 80e8cb6..8a0c553 100644 --- a/tests/test_events.py +++ b/tests/test_events.py @@ -1774,7 +1774,7 @@ ], }, { - "filename": "securities_transfer_incoming_null_eventType.json", + "filename": "securities_transfer_incoming_no_eventType.json", "event_type": PPEventType.TRANSFER_IN, "title": "MSCI EM USD (Acc)", "isin": "IE00BTJRMP35",