Unregister package before installing instead of unloading (#2437)

lionel- · web-flow · commit 7f4aa1f042e5 · 2022-07-20T10:56:39.000+02:00
Closes #2349
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # devtools (development version)
 
+* `install(reload = TRUE)` now calls `pkgload::unregister()` instead
+  of `pkload::unload()` (#2349). This allows the package to keep
+  functioning if it is still in use in the R session (e.g. through
+  event handlers).
+
 * `test()` no longer calls `load_all()` twice. `test_active_file()`
   now calls `load_all()` via testthat.
 
diff --git a/R/install.R b/R/install.R
@@ -96,7 +96,7 @@ install <-
     was_attached <- is_attached(pkg)
 
     if (reload && was_loaded) {
-      pkgload::unload(pkg$package)
+      pkgload::unregister(pkg$package)
     }
 
     pkgbuild::with_build_tools(required = FALSE,

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ install <-`
`96`	`96`	`was_attached <- is_attached(pkg)`
`97`	`97`
`98`	`98`	`if (reload && was_loaded) {`
`99`		`- pkgload::unload(pkg$package)`
	`99`	`+ pkgload::unregister(pkg$package)`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`pkgbuild::with_build_tools(required = FALSE,`