Skip to content

Commit 90142ce

Browse files
committed
Remove nodejs8.10 runtime support. Resolves #26
1 parent f5dd231 commit 90142ce

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
<h2 align="center">Background</h2>
1313

14-
This plugin will build your [AWS SAM CLI](https://github.com/awslabs/aws-sam-cli) project using Webpack. You can use it to replace the `sam build` step if every function in your SAM template uses the `nodejs8.10`, `nodejs10.x` or `nodejs12.x` runtime. If your project uses other runtimes then look at [Building Apps with SAM, TypeScript and VS Code Debugging](http://www.goingserverless.com/blog/building-apps-with-sam-typescript-and-vscode-debugging).
14+
This plugin will build your [AWS SAM CLI](https://github.com/awslabs/aws-sam-cli) project using Webpack. You can use it to replace the `sam build` step if every function in your SAM template uses the `nodejs10.x` or `nodejs12.x` runtime. If your project uses other runtimes then look at [Building Apps with SAM, TypeScript and VS Code Debugging](http://www.goingserverless.com/blog/building-apps-with-sam-typescript-and-vscode-debugging).
1515

1616
I started this project for two reasons:
1717

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ class AwsSamPlugin {
6363
throw new Error(`${resourceKey} is missing Properties`);
6464
}
6565
// Check the runtime is supported
66-
if (!["nodejs8.10", "nodejs10.x", "nodejs12.x"].includes(properties.Runtime ?? defaultRuntime)) {
67-
throw new Error(`${resourceKey} has an unsupport Runtime. Must be nodejs8.10, nodejs10.x or nodejs12.x`);
66+
if (!["nodejs10.x", "nodejs12.x"].includes(properties.Runtime ?? defaultRuntime)) {
67+
throw new Error(`${resourceKey} has an unsupport Runtime. Must be nodejs10.x or nodejs12.x`);
6868
}
6969

7070
// Continue with a warning if they're using inline code

0 commit comments

Comments
 (0)