Skip to content

Incorrect implementation of onTransitionEnd #914

@X-Y

Description

@X-Y

What is the current behavior?

addEndListener on Transition has two arguments, node and done. node is a function and done is undefined.

What is the expected behavior?

node should be the nodeRef and done should be a function

Look at this line:
https://github.com/reactjs/react-transition-group/blame/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/Transition.js#L350

if this.props.nodeRef exists, then maybeNode becomes this.nextCallback and maybeNextCallback becomes undefined?

Could you provide a CodeSandbox demo reproducing the bug?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions