Merge pull request #11 from clue-labs/error

Fix error reporting when trying to create invalid sockets

Author: cboden

src/Factory.php

@@ -25,7 +25,7 @@ public function createClient($address)
         $loop = $this->loop;
 
         return $this->resolveAddress($address)->then(function ($address) use ($loop) {
-            $socket = stream_socket_client($address, $errno, $errstr);
+            $socket = @stream_socket_client($address, $errno, $errstr);
             if (!$socket) {
                 throw new Exception('Unable to create client socket: ' . $errstr, $errno);
             }
@@ -40,7 +40,7 @@ public function createServer($address)
         $loop = $this->loop;
 
         return $this->resolveAddress($address)->then(function ($address) use ($loop) {
-            $socket = stream_socket_server($address, $errno, $errstr, STREAM_SERVER_BIND);
+            $socket = @stream_socket_server($address, $errno, $errstr, STREAM_SERVER_BIND);
             if (!$socket) {
                 throw new Exception('Unable to create server socket: ' . $errstr, $errno);
             }

tests/FactoryTest.php

@@ -1,16 +1,21 @@
 <?php
 
 use React\Datagram\Socket;
+use React\Datagram\Factory;
 use Clue\React\Block;
+use React\Promise;
 
 class FactoryTest extends TestCase
 {
+    private $loop;
+    private $resolver;
     private $factory;
 
     public function setUp()
     {
         $this->loop = React\EventLoop\Factory::create();
-        $this->factory = new React\Datagram\Factory($this->loop, $this->createResolverMock());
+        $this->resolver = $this->createResolverMock();
+        $this->factory = new Factory($this->loop, $this->resolver);
     }
 
     public function testCreateClient()
@@ -64,4 +69,54 @@ public function testCreateServerRandomPort()
 
         $capturedServer->close();
     }
+
+    public function testCreateClientWithIpWillNotUseResolver()
+    {
+        $this->resolver->expects($this->never())->method('resolve');
+
+        $client = Block\await($this->factory->createClient('127.0.0.1:0'), $this->loop);
+        $client->close();
+    }
+
+    public function testCreateClientWithHostnameWillUseResolver()
+    {
+        $this->resolver->expects($this->once())->method('resolve')->with('example.com')->willReturn(Promise\resolve('127.0.0.1'));
+
+        $client = Block\await($this->factory->createClient('example.com:0'), $this->loop);
+        $client->close();
+    }
+
+    public function testCreateClientWithHostnameWillRejectIfResolverRejects()
+    {
+        $this->resolver->expects($this->once())->method('resolve')->with('example.com')->willReturn(Promise\reject(new \RuntimeException('test')));
+
+        $this->setExpectedException('RuntimeException');
+        Block\await($this->factory->createClient('example.com:0'), $this->loop);
+    }
+
+    public function testCreateClientWithHostnameWillRejectIfNoResolverIsGiven()
+    {
+        $this->factory = new Factory($this->loop);
+
+        $this->setExpectedException('Exception');
+        Block\await($this->factory->createClient('example.com:0'), $this->loop);
+    }
+
+    /**
+     * @expectedException Exception
+     * @expectedExceptionMessage Unable to create client socket
+     */
+    public function testCreateClientWithInvalidHostnameWillReject()
+    {
+        Block\await($this->factory->createClient('/////'), $this->loop);
+    }
+
+    /**
+     * @expectedException Exception
+     * @expectedExceptionMessage Unable to create server socket
+     */
+    public function testCreateServerWithInvalidHostnameWillReject()
+    {
+        Block\await($this->factory->createServer('/////'), $this->loop);
+    }
 }