Skip to content

Commit 849b847

Browse files
committed
Merge branch 'refs/heads/master' into 0.4
Conflicts: CHANGELOG.md
2 parents 49bb03f + 518e12e commit 849b847

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

Resolver/Factory.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ protected function createCachedExecutor(LoopInterface $loop)
4646

4747
protected function addPortToServerIfMissing($nameserver)
4848
{
49-
return false === strpos($nameserver, ':') ? "$nameserver:53" : $nameserver;
49+
if (strpos($nameserver, '[') === false && substr_count($nameserver, ':') >= 2) {
50+
// several colons, but not enclosed in square brackets => enclose IPv6 address in square brackets
51+
$nameserver = '[' . $nameserver . ']';
52+
}
53+
// assume a dummy scheme when checking for the port, otherwise parse_url() fails
54+
if (parse_url('dummy://' . $nameserver, PHP_URL_PORT) === null) {
55+
$nameserver .= ':53';
56+
}
57+
58+
return $nameserver;
5059
}
5160
}

0 commit comments

Comments
 (0)