Skip to content

Commit e84048e

Browse files
committed
Merge pull request #34 from clue-labs/php
First class support for PHP7 and HHVM
2 parents a06b222 + 44aad11 commit e84048e

2 files changed

Lines changed: 3 additions & 25 deletions

File tree

.travis.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,11 @@ php:
77
- 5.6
88
- 7
99
- hhvm
10-
- hhvm-nightly
1110

12-
matrix:
13-
allow_failures:
14-
- php: 7
15-
- php: hhvm
16-
- php: hhvm-nightly
17-
fast_finish: true
11+
sudo: false
1812

19-
before_script:
20-
- composer install --dev --prefer-source
13+
install:
14+
- composer install --prefer-source --no-interaction
2115

2216
script:
2317
- phpunit --coverage-text

tests/Resolver/ResolverTest.php

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -100,22 +100,6 @@ public function resolveWithNoAnswersShouldCallErrbackIfGiven()
100100
$resolver->resolve('igor.io')->then($this->expectCallableNever(), $errback);
101101
}
102102

103-
/** @test */
104-
public function resolveSouldProvideDefaultErrorbackToExecutor()
105-
{
106-
$executor = $this->createExecutorMock();
107-
$executor
108-
->expects($this->once())
109-
->method('query')
110-
->with($this->anything(), $this->isInstanceOf('React\Dns\Query\Query'))
111-
->will($this->returnCallback(function ($nameserver, $query) {
112-
return Promise\resolve();
113-
}));;
114-
115-
$resolver = new Resolver('8.8.8.8:53', $executor);
116-
$resolver->resolve('igor.io')->then($this->expectCallableNever());
117-
}
118-
119103
protected function expectCallableOnceWith($with)
120104
{
121105
$mock = $this->createCallableMock();

0 commit comments

Comments
 (0)