Skip to content

Remove usage of junit within the app itself #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire-light43 merged 1 commit into from
May 21, 2026
+18 −14
Merged

Remove usage of junit within the app itself #2820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ dependencies {
testImplementation(libs.junit)
testImplementation(libs.json)
androidTestImplementation(libs.core)
implementation(libs.junit.ktx)
androidTestImplementation(libs.ext.junit)
androidTestImplementation(libs.espresso.core)
androidTestImplementation(libs.ext.junit)
androidTestImplementation(libs.junit.ktx)

// Android Core & Lifecycle
implementation(libs.core.ktx)
Expand Down
28 changes: 16 additions & 12 deletions app/src/main/java/com/lagradost/cloudstream3/utils/TestingUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ package com.lagradost.cloudstream3.utils
import com.lagradost.cloudstream3.*
import com.lagradost.cloudstream3.mvvm.logError
import kotlinx.coroutines.*
import org.junit.Assert
import kotlin.random.Random

object TestingUtils {

open class TestResult(val success: Boolean) {
companion object {
val Pass = TestResult(true)
Expand Down Expand Up @@ -48,6 +48,10 @@ object TestingUtils {
messageLog.add(Message(LogLevel.Error, message))
}
}

private fun fail(message: String): Nothing = throw AssertionError(message)
private fun assertTrue(message: String, condition: Boolean) { if (!condition) fail(message) }
private fun assertNotNull(message: String, value: Any?) { if (value == null) fail(message) }

class TestResultList(val results: List<SearchResponse>) : TestResult(true)
class TestResultLoad(val extractorData: String, val shouldLoadLinks: Boolean) : TestResult(true)
Expand Down Expand Up @@ -87,7 +91,7 @@ object TestingUtils {
} catch (e: Throwable) {
when (e) {
is NotImplementedError -> {
Assert.fail("Provider marked as hasMainPage, while in reality is has not been implemented")
fail("Provider marked as hasMainPage, while in reality is has not been implemented")
}

is CancellationException -> {
Expand Down Expand Up @@ -115,7 +119,7 @@ object TestingUtils {
api.search(query, 1)?.items?.takeIf { it.isNotEmpty() }
} catch (e: Throwable) {
if (e is NotImplementedError) {
Assert.fail("Provider has not implemented search()")
fail("Provider has not implemented search()")
} else if (e is CancellationException) {
throw e
}
Expand All @@ -125,7 +129,7 @@ object TestingUtils {
}

return if (searchResults.isNullOrEmpty()) {
Assert.fail("Api ${api.name} did not return any search responses")
fail("Api ${api.name} did not return any search responses")
TestResult.Fail // Should not be reached
} else {
TestResultList(searchResults)
Expand Down Expand Up @@ -216,7 +220,7 @@ object TestingUtils {
// return TestResult(validResults)
} catch (e: Throwable) {
if (e is NotImplementedError) {
Assert.fail("Provider has not implemented load()")
fail("Provider has not implemented load()")
}
throw e
}
Expand All @@ -228,14 +232,14 @@ object TestingUtils {
url: String?,
logger: Logger
): TestResult {
Assert.assertNotNull("Api ${api.name} has invalid url on episode", url)
assertNotNull("Api ${api.name} has invalid url on episode", url)
if (url == null) return TestResult.Fail // Should never trigger

var linksLoaded = 0
try {
val success = api.loadLinks(url, false, {}) { link ->
logger.log("Video loaded: ${link.name}")
Assert.assertTrue(
assertTrue(
"Api ${api.name} returns link with invalid url ${link.url}",
link.url.length > 4
)
Expand All @@ -245,12 +249,12 @@ object TestingUtils {
logger.log("Links loaded: $linksLoaded")
return TestResult(linksLoaded > 0)
} else {
Assert.fail("Api ${api.name} returns false on loadLinks() with $linksLoaded links loaded")
fail("Api ${api.name} returns false on loadLinks() with $linksLoaded links loaded")
}
} catch (e: Throwable) {
when (e) {
is NotImplementedError -> {
Assert.fail("Provider has not implemented loadLinks()")
fail("Provider has not implemented loadLinks()")
}

else -> {
Expand All @@ -276,7 +280,7 @@ object TestingUtils {

// Test Homepage
val homepage = testHomepage(api, logger)
Assert.assertTrue("Homepage failed to load", homepage.success)
assertTrue("Homepage failed to load", homepage.success)
val homePageList = (homepage as? TestResultList)?.results ?: emptyList()

// Test Search Results
Expand All @@ -287,7 +291,7 @@ object TestingUtils {
listOf("over", "iron", "guy")).take(3)

val searchResults = testSearch(api, searchQueries, logger)
Assert.assertTrue("Failed to get search results", searchResults.success)
assertTrue("Failed to get search results", searchResults.success)
searchResults as TestResultList

// Test Load and LoadLinks
Expand Down Expand Up @@ -321,4 +325,4 @@ object TestingUtils {
}
}
}
}
}