From 1e4b6de49ec0ec90a192ebde22bbd42c604873e6 Mon Sep 17 00:00:00 2001 From: Jamie Ruderman Date: Wed, 19 Aug 2026 15:03:27 -0700 Subject: [PATCH 1/2] ci(node): read the node version from .nvmrc instead of pinning it per workflow --- .github/workflows/build-android.yml | 2 +- .github/workflows/build-electron.yml | 2 +- .github/workflows/build-ios.yml | 2 +- .github/workflows/typecheck.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml index 4bda84d08..b9db9145d 100644 --- a/.github/workflows/build-android.yml +++ b/.github/workflows/build-android.yml @@ -48,7 +48,7 @@ jobs: - name: Install Node.js, NPM and Yarn uses: actions/setup-node@v3 with: - node-version: 22 + node-version-file: .nvmrc - name: Set npm version run: npm install -g npm@10 diff --git a/.github/workflows/build-electron.yml b/.github/workflows/build-electron.yml index 29953d398..9f53486ee 100644 --- a/.github/workflows/build-electron.yml +++ b/.github/workflows/build-electron.yml @@ -52,7 +52,7 @@ jobs: - name: Install Node.js, NPM and Yarn uses: actions/setup-node@v3 with: - node-version: 22 + node-version-file: .nvmrc - name: Set npm version run: npm install -g npm@10 diff --git a/.github/workflows/build-ios.yml b/.github/workflows/build-ios.yml index df62d4d21..3b3aa5015 100644 --- a/.github/workflows/build-ios.yml +++ b/.github/workflows/build-ios.yml @@ -33,7 +33,7 @@ jobs: - name: Install Node.js, NPM and Yarn uses: actions/setup-node@v3 with: - node-version: 22 + node-version-file: .nvmrc - name: Set npm version run: npm install -g npm@10 diff --git a/.github/workflows/typecheck.yml b/.github/workflows/typecheck.yml index 6957c7824..9f37eecd7 100644 --- a/.github/workflows/typecheck.yml +++ b/.github/workflows/typecheck.yml @@ -19,7 +19,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: - node-version: 22 + node-version-file: .nvmrc cache: npm - name: Authenticate with Font Awesome npm registry From 3a728f2c208e5f175e6a7c8b4e2b2003cfaa2568 Mon Sep 17 00:00:00 2001 From: Jamie Ruderman Date: Wed, 19 Aug 2026 15:16:32 -0700 Subject: [PATCH 2/2] ci(actions): bump setup-node to v4 off the deprecated node16 runtime --- .github/workflows/build-android.yml | 2 +- .github/workflows/build-electron.yml | 2 +- .github/workflows/build-ios.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml index b9db9145d..c2c307b69 100644 --- a/.github/workflows/build-android.yml +++ b/.github/workflows/build-android.yml @@ -46,7 +46,7 @@ jobs: run: chmod +x ./gradlew - name: Install Node.js, NPM and Yarn - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: .nvmrc diff --git a/.github/workflows/build-electron.yml b/.github/workflows/build-electron.yml index 9f53486ee..c1932f333 100644 --- a/.github/workflows/build-electron.yml +++ b/.github/workflows/build-electron.yml @@ -50,7 +50,7 @@ jobs: echo "VERSION=v$VERSION" >> $GITHUB_OUTPUT - name: Install Node.js, NPM and Yarn - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: .nvmrc diff --git a/.github/workflows/build-ios.yml b/.github/workflows/build-ios.yml index 3b3aa5015..4fff9a807 100644 --- a/.github/workflows/build-ios.yml +++ b/.github/workflows/build-ios.yml @@ -31,7 +31,7 @@ jobs: run: xcodebuild -version - name: Install Node.js, NPM and Yarn - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: .nvmrc