Skip to content

Commit 25ec005

Browse files
committed
umf: renumber gotcha references (549/550 -> 550/551, collision on main)
1 parent 979e9c9 commit 25ec005

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/build-umf.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
# numactl-devel is only needed to build UMF's own test suite (test/CMakeLists.txt), not
8282
# the library itself; it is in Rocky 10's appstream repo, no --enablerepo=crb needed.
8383
# --cap-add=SYS_PTRACE: UMF's IPC tests duplicate a memory-mapped fd across a
84-
# pid via pidfd_getfd(2) (gotcha 549), which Docker's default seccomp profile
84+
# pid via pidfd_getfd(2) (gotcha 550), which Docker's default seccomp profile
8585
# blocks (EPERM) without this capability, even for a process duplicating its own fd.
8686
- name: Build HWLOC, UMF, test it, and build the wheel
8787
run: |
@@ -95,7 +95,7 @@ jobs:
9595
export LD_LIBRARY_PATH=/work/hwloc-install/lib
9696
cmake -S . -B build-test -DCMAKE_BUILD_TYPE=Release -DUMF_BUILD_SHARED_LIBRARY=ON -DUMF_BUILD_LEVEL_ZERO_PROVIDER=ON -DUMF_BUILD_CUDA_PROVIDER=ON -DUMF_BUILD_TESTS=ON -DUMF_BUILD_GPU_TESTS=OFF -DUMF_BUILD_EXAMPLES=ON -DUMF_BUILD_GPU_EXAMPLES=OFF -DUMF_BUILD_BENCHMARKS=OFF -DCMAKE_INSTALL_LIBDIR=lib
9797
cmake --build build-test -j"$(nproc)"
98-
# gotcha 550: TrackingProviderPoolTest/umfPoolTest.multiThreadedpow2AlignedAlloc
98+
# gotcha 551: TrackingProviderPoolTest/umfPoolTest.multiThreadedpow2AlignedAlloc
9999
# crashes with SIGBUS on riscv64 under a nested tracking-provider stack; skipped
100100
# pending riscv64 hardware access to debug it interactively.
101101
export GTEST_FILTER="-TrackingProviderPoolTest/umfPoolTest.multiThreadedpow2AlignedAlloc/*"

0 commit comments

Comments
 (0)