Skip to content

Commit 92ea526

Browse files
committed
rerun-sdk: fix test_lerobot_reader.py assets + deselect test_optimized_stream.py's datafusion tests
The 9 remaining 0.38.1 test failures (0.38.0 shares the same test suite) split into two distinct root causes, not one: - test_lerobot_reader.py (5 tests): FileNotFoundError, not datafusion. CIBW_TEST_SOURCES only copied importer_mcap's own fixtures (${RE_IMPORTER_DIR}/src/importer_mcap/tests/assets); the new-in-0.38.x LeRobot fixtures live at the sibling path ${RE_IMPORTER_DIR}/tests/assets/lerobot and were never added. Add that path instead of ignoring the file -- it's a missing fixture, not a missing riscv64 wheel. The path exists (unused) in 0.37.2 too, so this is a no-op there. - test_optimized_stream.py (4 of its 8 tests): genuine ModuleNotFoundError: datafusion, via ChunkStore.reader()'s lazy `import datafusion` (same missing riscv64 wheel as test_datafusion_utils.py/test_server.py). Its other 4 tests don't call `.reader()` and pass, so deselect the 4 failing ones individually instead of ignoring the whole file -- same pattern already used for test_multi_stream.py::test_isolated_streams and test_send_dataframe.py::test_send_dataframe_roundtrip. Verified by grepping rerun-sdk's own test suite (rerun-io/rerun @ 0.38.1) for every `.reader(` and `import datafusion` usage: these are the only two files among the currently-collected tests that reach it.
1 parent 152a1ef commit 92ea526

1 file changed

Lines changed: 25 additions & 1 deletion

File tree

‎.github/workflows/build-rerun-sdk.yml‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,19 @@ jobs:
225225
# "Resolve re_importer crate path" step) and the animated_urdf
226226
# example data are the same shape for test_mcap_reader.py /
227227
# test_urdf_tree.py. Cargo.toml is test_version.py's own fixture
228-
# (it parses the workspace version straight out of it).
228+
# (it parses the workspace version straight out of it). The
229+
# `tests/assets/lerobot` fixtures (new in 0.38.x, present but unused
230+
# by any test in 0.37.2) are a sibling of importer_mcap under
231+
# `${RE_IMPORTER_DIR}/tests`, not under `src/importer_mcap/tests`;
232+
# test_lerobot_reader.py resolves them via
233+
# `Path(__file__).parents[3] / "crates/data_flow/re_importer/tests/
234+
# assets/lerobot"` and without this line the whole file fails with
235+
# `FileNotFoundError: LeRobot dataset not found` -- not a datafusion
236+
# issue, just a missing test-sources entry from the 0.38.x bump.
229237
CIBW_TEST_SOURCES: >-
230238
rerun_py/tests rerun_py/pyproject.toml tests/assets
231239
${{ env.RE_IMPORTER_DIR }}/src/importer_mcap/tests/assets
240+
${{ env.RE_IMPORTER_DIR }}/tests/assets/lerobot
232241
examples/rust/animated_urdf/data Cargo.toml
233242
# e2e_redap_tests needs the "server" Cargo feature (not built, see
234243
# the scope note above) to start its local catalog server.
@@ -256,6 +265,17 @@ jobs:
256265
# it hits the test's 5s join() timeout consistently on this
257266
# runner but not the reason any other test here was dropped --
258267
# deselect, don't chase (CLAUDE.md gotcha 14).
268+
# test_optimized_stream.py (new in 0.38.x) is the same "single
269+
# failures in an otherwise-passing file" shape as
270+
# test_multi_stream.py::test_isolated_streams and
271+
# test_send_dataframe.py::test_send_dataframe_roundtrip above: only
272+
# the 4 tests that call `ChunkStore.reader()` (which lazily does
273+
# `import datafusion` in rerun_sdk/rerun/chunk/_chunk_store.py, same
274+
# missing riscv64 wheel as test_datafusion_utils.py/test_server.py)
275+
# fail; its other 4 tests (test_merge_quality, test_layout_snapshot,
276+
# test_laziness, test_own_chunk_rules) don't touch `.reader()` and
277+
# pass, so they're deselected individually rather than the whole
278+
# file ignored.
259279
CIBW_TEST_COMMAND: >-
260280
cd rerun_py &&
261281
python -c "import rerun_bindings.rerun_bindings as m; assert m.__file__.endswith('.so'), m.__file__" &&
@@ -282,6 +302,10 @@ jobs:
282302
--deselect=tests/unit/test_multi_stream.py::test_isolated_streams
283303
--deselect=tests/unit/test_send_dataframe.py::test_send_dataframe_roundtrip
284304
--deselect=tests/unit/test_multiprocessing_gc.py::test_multiprocessing_gc
305+
--deselect=tests/integration/test_optimized_stream.py::test_data_equality
306+
--deselect=tests/integration/test_optimized_stream.py::test_chunk_store_path
307+
--deselect=tests/integration/test_optimized_stream.py::test_sweep_order_observable
308+
--deselect=tests/integration/test_optimized_stream.py::test_own_chunk_default
285309
286310
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
287311
with:

0 commit comments

Comments
 (0)