Allow specifying the mask and bbox keys in the GraphArrayView#293
Draft
cmalinmayor wants to merge 2 commits into
Draft
Allow specifying the mask and bbox keys in the GraphArrayView#293cmalinmayor wants to merge 2 commits into
cmalinmayor wants to merge 2 commits into
Conversation
cmalinmayor
force-pushed
the
multiple-masks-per-node
branch
from
7c56781 to
68bbb6a
Compare
Author
|
Force pushed to rebase onto rc3, so I can actually run tests without running into #294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to store two masks for each cell - the whole membrane and the nucleus segmentations - and display them both as GraphArrayViews in napari. This edit should keep the default behavior of "mask" and "bbox" if not specified, but allow you to specify.
Is there anywhere else in the repo where a single mask and bbox per node is assumed that I should be aware of to make sure I don't break any default behavior? @TeunHuijben @JoOkuma (tagging cause I can't request reviewers)
Second edit: immediately found more places when I tried to run a slightly different script, new commits coming 🙃