Merge pull request #173 from zzet/patch-1

rubenv · web-flow · commit eef9d3b68125 · 2020-04-23T19:16:38.000+02:00
fix: Quote `id` column as it described in dialect definition
diff --git a/migrate.go b/migrate.go
@@ -707,7 +707,7 @@ func (ms MigrationSet) GetMigrationRecords(db *sql.DB, dialect string) ([]*Migra
 	}
 
 	var records []*MigrationRecord
-	query := fmt.Sprintf("SELECT * FROM %s ORDER BY id ASC", dbMap.Dialect.QuotedTableForQuery(ms.SchemaName, ms.getTableName()))
+	query := fmt.Sprintf("SELECT * FROM %s ORDER BY %s ASC", dbMap.Dialect.QuotedTableForQuery(ms.SchemaName, ms.getTableName()), dbMap.Dialect.QuoteField("id"))
 	_, err = dbMap.Select(&records, query)
 	if err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,7 @@ func (ms MigrationSet) GetMigrationRecords(db sql.DB, dialect string) ([]Migra`
`707`	`707`	`}`
`708`	`708`
`709`	`709`	`var records []*MigrationRecord`
`710`		`- query := fmt.Sprintf("SELECT * FROM %s ORDER BY id ASC", dbMap.Dialect.QuotedTableForQuery(ms.SchemaName, ms.getTableName()))`
	`710`	`+ query := fmt.Sprintf("SELECT * FROM %s ORDER BY %s ASC", dbMap.Dialect.QuotedTableForQuery(ms.SchemaName, ms.getTableName()), dbMap.Dialect.QuoteField("id"))`
`711`	`711`	`_, err = dbMap.Select(&records, query)`
`712`	`712`	`if err != nil {`
`713`	`713`	`return nil, err`