Unable to specify multiple teams as owners

[MrLukeSmith]

The syntax for CODEOWNERS, as described by GitHub, permits multiple owners.

E.g.

/scripts/ @doctocat @octocat

code_ownership doesn't appear to support this (I've tried lots of permutations, none work. Documentation only ever references team in the singular). It'd be great if it were able to accept a comma separated string, one per line for the file type, or something like that 🤷. Allowing us to define multiple teams as owners of areas.

# .codeowner
Team One, Team Two

or

# @team Team One, Team Two

[frostevent]

+1

It would be nice to allow a file to be owned by different teams.

For example team1.yml:

name: Team1
owned_globs:
 - app/services/users/**/*

and team2.yml:

name: Team2
owned_globs:
 - app/services/users/send_notification.rb

would result in:

app/services/users/**/* @Team1
app/services/users/send_notification.rb @Team2

It's particularly useful when trying to break apart a monolith. Team1 owns most of app/services/users/ while Team2 owns send_notification.rb, but Team2 hasn't moved the file elsewhere yet because either it still contains code Team1 owns or it doesn't have another home yet. Both teams are still interested in changes to that file.

[ashleywillard]

Hi @MrLukeSmith and @frostevent! Please see this issue from February on the same topic: #86

If you want to pursue this functionality in a way that is opt-in, we're open to review it. We'd like to be able to continue to require one owner per file, but having an option to change that setting would be fine. Alex wrote:

"Typically I've dealt with that by finding ways to improve the boundaries/responsibility of the file. The tool as originally designed was meant to be opinionated such that mega-files with too much responsibility go against the grain a bit.

The benefit of this is the tool becomes a lot easier to maintain and use in a lot of ways, although might be interesting to support it as an isolated experiment to better understand how it affects the structure and usage of the tool!"

[martinemde]

If #116 was fixed, you could add unowned_globs for team1 in to exclude the file that team2 owns.