Last Item Ignored

[baoqiangy]

I tested a small file with 4 elements in there. I noticed that the last element is always ignored. Is it because you code return an empty element as the first one and by the time the last element is read, the parser simply thinks it is done?

[gonzofy]

@baoqiangy That's not a problem I've ever had with the parser. Without knowing the specifics, I suspect it's a mistake in your Listener implementation.

[baoqiangy]

Here is the modified code of the example_geojson.php, I only changed the file to use small_json.json and print the json every time a json is recognized.

`<?php

require_once '/../vendor/autoload.php';

$testfile = 'small_json.json';

$listener = new \JsonStreamingParser\Listener\GeoJsonListener(function ($item) {
print_r($item);
});
$stream = fopen($testfile, 'r');
try {
$parser = new \JsonStreamingParser\Parser($stream, $listener);
$parser->parse();
fclose($stream);
} catch (Exception $e) {
fclose($stream);
throw $e;
}`

Here is the json file I used (small_json.json).

[ { "id": 707860, "name": "Hurzuf", "country": "UA", "coord": { "lon": 34.283333, "lat": 44.549999 } }, { "id": 519188, "name": "Novinki", "country": "RU", "coord": { "lon": 37.666668, "lat": 55.683334 } }, { "id": 1283378, "name": "Gorkhā", "country": "NP", "coord": { "lon": 84.633331, "lat": 28 } }, { "id": 1270260, "name": "State of Haryāna", "country": "IN", "coord": { "lon": 76, "lat": 29 } } ]

Here is the output when I execute the example_test.php in a browser on localhost.
`Array ( [id] => 707860 [name] => Hurzuf [country] => UA [coord] => Array ( [lon] => 34.283333 [lat] => 44.549999 ) )
Array ( [id] => 519188 [name] => Novinki [country] => RU [coord] => Array ( [lon] => 37.666668 [lat] => 55.683334 ) )
Array ( [id] => 1283378 [name] => Gorkhā [country] => NP [coord] => Array ( [lon] => 84.633331 [lat] => 28 ) )

`

Apparently, the last one is not printed. I could not figure out what caused this.

[gonzofy]

Got it. I suspect it's a problem with the logic in the GeoJsonListener class.

Specifically, this logic:

        // Call the callback when returning to the second level
        if ($this->level == 2 && is_callable($this->callback)) {
            call_user_func($this->callback, $this->json);
        }

Since the last element doesn't return to level 2. I don't use the GeoJsonListener myself; the fix looks easy enough, so if you figure it out and submit a pull request I'd be happy to merge.

[sg3w]

I`ve got the same Problem and the same Node has many hits. The Return-Level is 1.

if (1 === $this->level && \is_callable($this->callback)) { \call_user_func($this->callback, $this->json); }