Summary
selectFormStrategy_AddFuelView_L3(layout:) currently ignores layout and returns a hardcoded FormStrategy (.form / .standard / .realTime). Production comments say this is temporary until the intelligent system lands.
Found while making L3 unit tests honest under #382 — the old test implied layout→strategy mapping by comparing strategy fields to the input layout while feeding values that matched the hardcode.
Desired behavior
- Strategy fields should derive from (or at least respect) the supplied
FormLayoutDecision, or
- If hardcoding remains intentional for a named domain stub, document that clearly in API docs and drop the unused
layout parameter (or rename / replace with a non-misleading API).
Out of scope
#382 only fixes the test to assert the current hardcoded contract (and documents ignore-layout). Product change lives here.
References
Summary
selectFormStrategy_AddFuelView_L3(layout:)currently ignoreslayoutand returns a hardcodedFormStrategy(.form/.standard/.realTime). Production comments say this is temporary until the intelligent system lands.Found while making L3 unit tests honest under #382 — the old test implied layout→strategy mapping by comparing strategy fields to the input layout while feeding values that matched the hardcode.
Desired behavior
FormLayoutDecision, orlayoutparameter (or rename / replace with a non-misleading API).Out of scope
#382 only fixes the test to assert the current hardcoded contract (and documents ignore-layout). Product change lives here.
References
Framework/Sources/Layers/Layer3-Strategy/PlatformStrategySelectionLayer3.swift—selectFormStrategy_AddFuelView_L3