🎨 优化窗口打开逻辑

Author: CodFrm

packages/message/server.ts

@@ -84,6 +84,7 @@ export class Server {
             })
             .catch((e: Error) => {
               con.sendMessage({ code: -1, message: e.message || e.toString() });
+              this.logger.error("connectHandle error", Logger.E(e));
             });
           return true;
         } else {
@@ -106,13 +107,15 @@ export class Server {
             })
             .catch((e: Error) => {
               sendResponse({ code: -1, message: e.message || e.toString() });
+              this.logger.error("messageHandle error", Logger.E(e));
             });
           return true;
         } else {
           sendResponse({ code: 0, data: ret });
         }
       } catch (e: any) {
         sendResponse({ code: -1, message: e.message || e.toString() });
+        this.logger.error("messageHandle error", Logger.E(e));
       }
     } else {
       sendResponse({ code: -1, message: "no such api " + action });

src/app/logger/logger.ts

@@ -96,6 +96,7 @@ export default class Logger {
       return { error: e };
     }
     if (e instanceof Error) {
+      console.error(e);
       return { error: e.message };
     }
     if (typeof e === "object") {

src/app/service/service_worker/gm_api.ts

@@ -310,8 +310,9 @@ export default class GMApi {
   }
 
   @PermissionVerify.API()
-  CAT_userConfig(request: Request): void {
-    openInCurrentTab(`/src/options.html#/?userConfig=${request.uuid}`);
+  CAT_userConfig(request: Request, sender: GetSender): void {
+    const { tabId } = sender.getExtMessageSender();
+    openInCurrentTab(`/src/options.html#/?userConfig=${request.uuid}`, tabId === -1 ? undefined : tabId);
   }
 
   @PermissionVerify.API({

src/app/service/service_worker/permission_verify.ts

@@ -150,7 +150,7 @@ export default class PermissionVerify {
       return;
     }
     try {
-      const ret = await this.confirm(data.request, data.confirm);
+      const ret = await this.confirm(data.request, data.confirm, data.sender);
       data.resolve(ret);
     } catch (e) {
       data.reject(e);
@@ -169,7 +169,7 @@ export default class PermissionVerify {
     });
   }
 
-  async confirm(request: Request, confirm: boolean | ConfirmParam): Promise<boolean> {
+  async confirm(request: Request, confirm: boolean | ConfirmParam, sender: GetSender): Promise<boolean> {
     if (typeof confirm === "boolean") {
       return confirm;
     }
@@ -194,7 +194,7 @@ export default class PermissionVerify {
       throw new Error("permission denied");
     }
     // 没有权限,则弹出页面让用户进行确认
-    const userConfirm = await this.confirmWindow(request.script, confirm);
+    const userConfirm = await this.confirmWindow(request.script, confirm, sender);
     // 成功存入数据库
     const model: Permission = {
       uuid: request.uuid,
@@ -250,7 +250,7 @@ export default class PermissionVerify {
   > = new Map();
 
   // 弹出窗口让用户进行确认
-  async confirmWindow(script: Script, confirm: ConfirmParam): Promise<UserConfirm> {
+  async confirmWindow(script: Script, confirm: ConfirmParam, sender: GetSender): Promise<UserConfirm> {
     return new Promise((resolve, reject) => {
       const uuid = uuidv4();
       // 超时处理
@@ -269,7 +269,8 @@ export default class PermissionVerify {
         reject,
       });
       // 打开窗口
-      openInCurrentTab(`src/confirm.html?uuid=${uuid}`);
+      const { tabId } = sender.getExtMessageSender();
+      openInCurrentTab(`src/confirm.html?uuid=${uuid}`, tabId === -1 ? undefined : tabId);
     });
   }
 

src/pkg/utils/utils.ts

@@ -145,9 +145,13 @@ export function getIcon(script: Script): string | undefined {
   );
 }
 
-// 在当前页后打开一个新页面
-export async function openInCurrentTab(url: string) {
-  const tab = await getCurrentTab();
+export async function getTab(tabId: number) {
+  return await chrome.tabs.get(tabId).catch(() => undefined);
+}
+
+// 在当前页后打开一个新页面，如果指定tabId则在该tab后打开
+export async function openInCurrentTab(url: string, tabId?: number) {
+  const tab = await (tabId ? getTab(tabId) : getCurrentTab());
   const createProperties: chrome.tabs.CreateProperties = { url };
   if (tab) {
     // 添加 openerTabId 有可能出现 Error "Tab opener must be in the same window as the updated tab."