Skip to content

Commit 8587df1

Browse files
committed
show current theme in settings selector
1 parent bf30973 commit 8587df1

4 files changed

Lines changed: 22 additions & 19 deletions

File tree

packages/newtab/newtab.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@
109109
</div>
110110
</footer>
111111

112-
<script type="text/javascript" src="script.js"></script>
113112
<script type="text/javascript" src="colors.js"></script>
113+
<script type="text/javascript" src="script.js"></script>
114114
<script type="text/javascript" src="export.js"></script>
115115
</body>
116116

packages/sidebar/panel.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@
109109
</div>
110110
</footer>
111111

112-
<script type="text/javascript" src="script.js"></script>
113112
<script type="text/javascript" src="colors.js"></script>
113+
<script type="text/javascript" src="script.js"></script>
114114
<script type="text/javascript" src="export.js"></script>
115115
</body>
116116

shared/colors.js

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,8 @@ const colorManager = {
158158
// Update theme toggle aria-label
159159
const themeToggle = document.getElementById('theme-toggle');
160160
if (themeToggle) {
161-
const nextTheme = this.getNextTheme(themeName);
162-
const isNextDark = nextTheme === 'dark' || nextTheme === 'frappe';
163-
themeToggle.setAttribute('aria-label', `Switch to ${isNextDark ? 'light' : 'dark'} theme`);
161+
const isCurrentDark = isDarkMode;
162+
themeToggle.setAttribute('aria-label', `Switch to ${isCurrentDark ? 'light' : 'dark'} theme`);
164163
}
165164
},
166165

@@ -225,7 +224,25 @@ const colorManager = {
225224
}
226225
};
227226

227+
// Initialize theme selector dropdown value
228+
const initThemeSelector = () => {
229+
const currentTheme = colorManager.getCurrentTheme();
230+
const themeSelector = document.getElementById('theme-selector');
231+
if (themeSelector) {
232+
themeSelector.value = currentTheme;
233+
}
234+
};
235+
228236
// Initialize on DOM load
229237
document.addEventListener('DOMContentLoaded', () => {
238+
// Initialize default variants for new themes if not set
239+
if (!localStorage.getItem('nord-variant')) {
240+
localStorage.setItem('nord-variant', 'light');
241+
}
242+
if (!localStorage.getItem('solarized-variant')) {
243+
localStorage.setItem('solarized-variant', 'light');
244+
}
245+
230246
colorManager.init();
247+
initThemeSelector();
231248
});

shared/script.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,6 @@ if (storedFontFamily) {
250250
updateFontFamily(storedFontFamily);
251251
}
252252

253-
// Init Theme Selector
254-
const currentTheme = colorManager.getCurrentTheme();
255-
if (els.themeSelector) {
256-
els.themeSelector.value = currentTheme;
257-
}
258-
259253
// Migrate legacy theme storage for backward compatibility
260254
const migrateLegacyTheme = () => {
261255
const legacyTheme = localStore.get("theme");
@@ -274,14 +268,6 @@ const migrateLegacyTheme = () => {
274268
// Remove old theme key
275269
localStore.remove("theme");
276270
}
277-
278-
// Initialize default variants for new themes if not set
279-
if (!localStorage.getItem('nord-variant')) {
280-
localStorage.setItem('nord-variant', 'light');
281-
}
282-
if (!localStorage.getItem('solarized-variant')) {
283-
localStorage.setItem('solarized-variant', 'light');
284-
}
285271
};
286272

287273
migrateLegacyTheme();

0 commit comments

Comments
 (0)