Reactive workspace propagation via WorkspacePathChanged event

- Add WorkspacePathChanged event to MainWindowViewModel (SSOT notification)
- Fire event from ApplyActiveMcpBaseUrl after setting workspace path
- Subscribe TodoListViewModel, WorkspaceViewModel, VoiceConversationViewModel
  at creation time — reactive refresh replaces imperative ordering
- Remove imperative child VM refresh from RefreshAllViewsForConnectionChangeAsync
- Remove premature auto-load from OnLoaded in PhoneTodoView, TodoListView
  (Android + Desktop) — workspace event handles initial load
- Fix _suppressWorkspaceSelectionChanged exception safety with try-finally

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: sharpninja

src/McpServerManager.Android/Views/PhoneTodoView.axaml.cs

@@ -55,9 +55,9 @@ private void OnAttachedToVisualTree(object? sender, VisualTreeAttachmentEventArg
 
     private async void OnLoaded(object? sender, RoutedEventArgs e)
     {
+        // No auto-load here — workspace-change event triggers the initial load
+        // after the correct workspace path is set on the shared MCP client.
         _hasAutoLoaded = true;
-        if (DataContext is TodoListViewModel vm && vm.GroupedItems.Count == 0 && !vm.IsLoading)
-            await vm.LoadTodosCommand.ExecuteAsync(null);
     }
 
     private void OnDataContextChanged(object? sender, EventArgs e)
@@ -77,9 +77,6 @@ private void OnDataContextChanged(object? sender, EventArgs e)
 
         SyncEditorFromViewModel(_currentVm);
         RefreshFormattedDetailFromViewModel();
-
-        if (_hasAutoLoaded && _currentVm.GroupedItems.Count == 0 && !_currentVm.IsLoading)
-            _ = _currentVm.LoadTodosCommand.ExecuteAsync(null);
     }
 
     private void OnViewModelPropertyChanged(object? sender, PropertyChangedEventArgs e)

src/McpServerManager.Android/Views/TodoListView.axaml.cs

@@ -34,11 +34,10 @@ public void SaveSettings()
             SaveCurrentSplitterToSettings(_wasPortrait.Value);
     }
 
-    private async void OnLoaded(object? sender, Avalonia.Interactivity.RoutedEventArgs e)
+    private void OnLoaded(object? sender, Avalonia.Interactivity.RoutedEventArgs e)
     {
+        // No auto-load — workspace-change event triggers the initial load.
         _hasAutoLoaded = true;
-        if (DataContext is TodoListViewModel vm && vm.GroupedItems.Count == 0 && !vm.IsLoading)
-            await vm.LoadTodosCommand.ExecuteAsync(null);
     }
 
     private void OnDataContextChanged(object? sender, EventArgs e)
@@ -47,9 +46,6 @@ private void OnDataContextChanged(object? sender, EventArgs e)
         {
             vm.GetEditorText = () => Editor.Text;
             vm.PropertyChanged += OnViewModelPropertyChanged;
-            // Auto-load if DataContext arrived after Loaded event
-            if (_hasAutoLoaded && vm.GroupedItems.Count == 0 && !vm.IsLoading)
-                _ = vm.LoadTodosCommand.ExecuteAsync(null);
         }
     }
 

src/McpServerManager.Core/ViewModels/MainWindowViewModel.cs

@@ -68,6 +68,9 @@ public partial class MainWindowViewModel : ViewModelBase, Commands.ICommandTarge
     internal readonly Mediator _mediator = new();
     private static readonly ILogger _logger = AppLogService.Instance.CreateLogger("ViewModel");
 
+    /// <summary>Raised when the active workspace path changes. Child VMs subscribe to refresh reactively.</summary>
+    public event Action<string>? WorkspacePathChanged;
+
     /// <summary>ViewModel for the Todo tab. Created lazily on first access.</summary>
     public TodoListViewModel TodoViewModel => _todoViewModel ??= CreateTodoViewModel();
     private TodoListViewModel? _todoViewModel;
@@ -76,6 +79,7 @@ private TodoListViewModel CreateTodoViewModel()
     {
         var vm = new TodoListViewModel(_clipboardService, _mcpTodoService);
         vm.GlobalStatusChanged += msg => DispatchToUi(() => StatusMessage = msg);
+        WorkspacePathChanged += path => DispatchToUi(() => _ = vm.RefreshForConnectionChangeAsync());
         return vm;
     }
 
@@ -88,6 +92,7 @@ private WorkspaceViewModel CreateWorkspaceViewModel()
         var vm = new WorkspaceViewModel(_clipboardService, _mcpWorkspaceService);
         vm.GlobalStatusChanged += msg => DispatchToUi(() => StatusMessage = msg);
         vm.WorkspaceCatalogChanged += change => _ = RefreshWorkspacePickerAfterCatalogChangeAsync(change);
+        WorkspacePathChanged += path => DispatchToUi(() => _ = vm.RefreshForConnectionChangeAsync());
         return vm;
     }
 
@@ -128,6 +133,7 @@ private VoiceConversationViewModel CreateVoiceConversationViewModel()
                 ?? string.Empty
         };
         vm.GlobalStatusChanged += msg => DispatchToUi(() => StatusMessage = msg);
+        WorkspacePathChanged += path => DispatchToUi(() => _ = vm.RefreshForConnectionChangeAsync());
         return vm;
     }
 
@@ -434,6 +440,9 @@ private void ApplyActiveMcpBaseUrl(string mcpBaseUrl, string? mcpApiKey = null,
 
         if (_hasRegisteredCqrsHandlers)
             RegisterMcpServiceHandlers();
+
+        // Notify child VMs reactively — they self-refresh without imperative ordering.
+        WorkspacePathChanged?.Invoke(resolvedPath);
     }
 
     private async Task<string?> ResolveActiveConnectionApiKeyAsync(WorkspaceConnectionOption option, string baseUrl)
@@ -1062,8 +1071,14 @@ private void ApplyWorkspaceConnectionOptions(
             ?? WorkspaceConnections[0];
 
         _suppressWorkspaceSelectionChanged = true;
-        SelectedWorkspaceConnection = selected;
-        _suppressWorkspaceSelectionChanged = false;
+        try
+        {
+            SelectedWorkspaceConnection = selected;
+        }
+        finally
+        {
+            _suppressWorkspaceSelectionChanged = false;
+        }
 
         // Initial picker population suppresses selection-changed switching to avoid duplicate work,
         // but we still need one real connection switch to set workspace path and refresh views.
@@ -1164,6 +1179,7 @@ await DispatchToUiAsync(() =>
 
     private async Task RefreshAllViewsForConnectionChangeAsync()
     {
+        // Session logs are owned by MainWindowViewModel — refresh directly.
         _logger.LogDebug("[Workspace Switch] Refreshing session logs...");
         try
         {
@@ -1176,52 +1192,8 @@ private async Task RefreshAllViewsForConnectionChangeAsync()
                 ex.GetType().Name, ex.Message);
         }
 
-        if (_todoViewModel != null)
-        {
-            _logger.LogDebug("[Workspace Switch] Refreshing todo view...");
-            try
-            {
-                await _todoViewModel.RefreshForConnectionChangeAsync().ConfigureAwait(true);
-                _logger.LogDebug("[Workspace Switch] Todo view refreshed OK");
-            }
-            catch (Exception ex)
-            {
-                _logger.LogWarning(ex, "[Workspace Switch] Todo refresh failed ({ExType}: {ExMsg}); continuing",
-                    ex.GetType().Name, ex.Message);
-            }
-        }
-
-        if (_workspaceViewModel != null)
-        {
-            _logger.LogDebug("[Workspace Switch] Refreshing workspace view...");
-            try
-            {
-                await _workspaceViewModel.RefreshForConnectionChangeAsync().ConfigureAwait(true);
-                _logger.LogDebug("[Workspace Switch] Workspace view refreshed OK");
-            }
-            catch (Exception ex)
-            {
-                _logger.LogWarning(ex, "[Workspace Switch] Workspace view refresh failed ({ExType}: {ExMsg}); continuing",
-                    ex.GetType().Name, ex.Message);
-            }
-        }
-
-        if (_voiceConversationViewModel != null)
-        {
-            _logger.LogDebug("[Workspace Switch] Refreshing voice view...");
-            try
-            {
-                _voiceConversationViewModel.WorkspacePath = _mcpClient.WorkspacePath ?? string.Empty;
-                await _voiceConversationViewModel.RefreshForConnectionChangeAsync().ConfigureAwait(true);
-                _logger.LogDebug("[Workspace Switch] Voice view refreshed OK");
-            }
-            catch (Exception ex)
-            {
-                _logger.LogWarning(ex, "[Workspace Switch] Voice refresh failed ({ExType}: {ExMsg}); continuing",
-                    ex.GetType().Name, ex.Message);
-            }
-        }
-
+        // Child VMs (Todo, Workspace, Voice) are refreshed reactively via
+        // WorkspacePathChanged event — no imperative calls needed here.
         _logger.LogDebug("[Workspace Switch] All views refreshed.");
     }
 

src/McpServerManager.Desktop/Views/TodoListView.axaml.cs

@@ -59,12 +59,10 @@ public void OnHostSizeChanged(Size newSize)
         }
     }
 
-    private async void OnLoaded(object? sender, Avalonia.Interactivity.RoutedEventArgs e)
+    private void OnLoaded(object? sender, Avalonia.Interactivity.RoutedEventArgs e)
     {
-        if (_hasAutoLoaded) return;
+        // No auto-load — workspace-change event triggers the initial load.
         _hasAutoLoaded = true;
-        if (DataContext is TodoListViewModel vm)
-            await vm.LoadTodosCommand.ExecuteAsync(null);
     }
 
     private void OnDataContextChanged(object? sender, EventArgs e)