Skip to content

Commit 1496166

Browse files
committed
chore: switch to latest shelljs, update tests
1 parent c6f76f1 commit 1496166

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@
3131
"eslint-config-airbnb-base": "^4.0.2",
3232
"eslint-plugin-import": "^1.11.1",
3333
"mocha": "^2.5.3",
34-
"shelljs": "github:shelljs/shelljs",
34+
"shelljs": "^0.7.3",
3535
"shelljs-changelog": "^0.2.2",
3636
"shelljs-release": "^0.2.0",
3737
"should": "^10.0.0"
3838
},
3939
"peerDependencies": {
40-
"shelljs": "github:shelljs/shelljs"
40+
"shelljs": "^0.7.3"
4141
}
4242
}

test/test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,23 +44,23 @@ describe('plugin-open', function () {
4444
* Plugins automatically add new commands to the ShellJS instance, such as
4545
* shell.open()
4646
*/
47-
(typeof shell.open).should.equal('function');
47+
shell.open.should.be.type('function');
4848
});
4949

5050
it('gets added to the global namespace for shelljs/global', function () {
5151
/*
5252
* Plugins are also compatible with using require('shelljs/global');
5353
*/
54-
(typeof global.open).should.equal('function');
54+
global.open.should.be.type('function');
5555
global.open.should.equal(shell.open);
5656
});
5757

5858
it('does not override other commands or methods', function () {
5959
/*
6060
* Plugins shouldn't interfere with existing commands
6161
*/
62-
(typeof shell.cp).should.equal('function');
63-
(typeof shell.mv).should.equal('function');
62+
shell.cp.should.be.type('function');
63+
shell.mv.should.be.type('function');
6464
shell.ls().should.have.property('toEnd');
6565
shell.ls().should.have.property('grep');
6666
shell.ls().should.have.property('sed');
@@ -70,9 +70,9 @@ describe('plugin-open', function () {
7070
/*
7171
* A plugin author can also export the implementation of their commands
7272
*/
73-
(typeof pluginOpen).should.equal('object');
73+
pluginOpen.should.be.type('object');
7474
pluginOpen.should.have.property('open');
75-
(typeof pluginOpen.open).should.equal('function');
75+
pluginOpen.open.should.be.type('function');
7676
});
7777

7878
it('does not accept options/flags', function () {

0 commit comments

Comments
 (0)