refactor: code cleanup, remove unused session commands

Author: rocwind

src/command-parser.ts

@@ -171,33 +171,6 @@ function removeCollaborator(commandName: string, yargs: yargs.Argv): void {
   addCommonConfiguration(yargs);
 }
 
-function sessionList(commandName: string, yargs: yargs.Argv): void {
-  isValidCommand = true;
-  yargs
-    .usage(USAGE_PREFIX + " session " + commandName + " [options]")
-    .demand(/*count*/ 0, /*max*/ 0)
-    .example("session " + commandName, "Lists your sessions in tabular format")
-    .example("session " + commandName + " --format json", "Lists your login sessions in JSON format")
-    .option("format", {
-      default: "table",
-      demand: false,
-      description: 'Output format to display your login sessions with ("json" or "table")',
-      type: "string",
-    });
-
-  addCommonConfiguration(yargs);
-}
-
-function sessionRemove(commandName: string, yargs: yargs.Argv): void {
-  isValidCommand = true;
-  yargs
-    .usage(USAGE_PREFIX + " session " + commandName + " <machineName>")
-    .demand(/*count*/ 1, /*max*/ 1) // Require exactly one non-option arguments
-    .example("session " + commandName + ' "John\'s PC"', 'Removes the existing login session from "John\'s PC"');
-
-  addCommonConfiguration(yargs);
-}
-
 function deploymentHistoryClear(commandName: string, yargs: yargs.Argv): void {
   isValidCommand = true;
   yargs

src/definitions/cli.ts

@@ -31,8 +31,6 @@ export enum CommandType {
   releaseCordova,
   releaseReact,
   rollback,
-  sessionList,
-  sessionRemove,
   whoami,
 }
 

src/release-hooks/core-release.ts

@@ -1,16 +1,17 @@
 import fs from "fs";
 import path from "path";
 import recursiveFs from "recursive-fs";
-import slash = require("slash");
 import yazl from "yazl";
-var progress = require("progress");
 
-import AccountManager = require("code-push");
 import { Package, PackageInfo } from "code-push/script/types";
 import { out } from "../util/interaction";
 import { generateRandomFilename } from "../lib/file-utils";
 import * as cli from "../definitions/cli";
-import ReleaseFile = cli.ReleaseFile;
+
+import slash = require("slash");
+const progress = require("progress");
+
+import AccountManager = require("code-push");
 
 var coreReleaseHook: cli.ReleaseHook = (
   currentCommand: cli.IReleaseCommand,
@@ -19,7 +20,7 @@ var coreReleaseHook: cli.ReleaseHook = (
 ): Promise<cli.IReleaseCommand> => {
   return Promise.resolve(<void>null)
     .then(() => {
-      var releaseFiles: ReleaseFile[] = [];
+      var releaseFiles: cli.ReleaseFile[] = [];
 
       if (!fs.lstatSync(currentCommand.package).isDirectory()) {
         releaseFiles.push({
@@ -29,7 +30,7 @@ var coreReleaseHook: cli.ReleaseHook = (
         return Promise.resolve(releaseFiles);
       }
 
-      return new Promise<ReleaseFile[]>((resolve, reject) => {
+      return new Promise<cli.ReleaseFile[]>((resolve, reject) => {
         var directoryPath: string = currentCommand.package;
         var baseDirectoryPath = path.join(directoryPath, ".."); // For legacy reasons, put the root directory in the zip
 
@@ -53,7 +54,7 @@ var coreReleaseHook: cli.ReleaseHook = (
         });
       });
     })
-    .then((releaseFiles: ReleaseFile[]) => {
+    .then((releaseFiles: cli.ReleaseFile[]) => {
       return new Promise<string>((resolve, reject): void => {
         var packagePath: string = path.join(process.cwd(), generateRandomFilename(15) + ".zip");
         var zipFile = new yazl.ZipFile();
@@ -68,7 +69,7 @@ var coreReleaseHook: cli.ReleaseHook = (
             resolve(packagePath);
           });
 
-        releaseFiles.forEach((releaseFile: ReleaseFile) => {
+        releaseFiles.forEach((releaseFile: cli.ReleaseFile) => {
           zipFile.addFile(releaseFile.sourceLocation, releaseFile.targetLocation);
         });