Unnecessary Shared Pointer Copies

Author: frs69wq

include/dtlmod/Engine.hpp

@@ -135,16 +135,16 @@ class Engine {
 
   /// @brief Put a Variable in the DTL using a specific Engine.
   /// @param var The variable to put in the DTL
-  void put(std::shared_ptr<Variable> var) const;
+  void put(const std::shared_ptr<Variable>& var) const;
 
   /// @brief Put a Variable in the DTL using a specific Engine.
   /// @param var The variable to put in the DTL
   /// @param simulated_size_in_bytes The simulated size of the Variable (can be different of actual size)
-  void put(std::shared_ptr<Variable> var, size_t simulated_size_in_bytes) const;
+  void put(const std::shared_ptr<Variable>& var, size_t simulated_size_in_bytes) const;
 
   /// @brief Get a Variable from the DTL
   /// @param var The Variable to get in the DTL (Have to do an Inquire first).
-  void get(std::shared_ptr<Variable> var) const;
+  void get(const std::shared_ptr<Variable>& var) const;
 
   /// @brief End a transaction on an Engine.
   void end_transaction();

src/Engine.cpp

@@ -35,18 +35,18 @@ void Engine::begin_transaction()
 }
 
 /// The actual data transport is delegated to the Transport method associated to the Engine.
-void Engine::put(std::shared_ptr<Variable> var) const
+void Engine::put(const std::shared_ptr<Variable>& var) const
 {
   transport_->put(var, var->get_local_size());
 }
 
-void Engine::put(std::shared_ptr<Variable> var, size_t simulated_size_in_bytes) const
+void Engine::put(const std::shared_ptr<Variable>& var, size_t simulated_size_in_bytes) const
 {
   transport_->put(var, simulated_size_in_bytes);
 }
 
 /// The actual data transport is delegated to the Transport method associated to the Engine.
-void Engine::get(std::shared_ptr<Variable> var) const
+void Engine::get(const std::shared_ptr<Variable>& var) const
 {
   transport_->get(var);
 }

src/bindings/python/dtlmod_python.cpp

@@ -170,9 +170,9 @@ PYBIND11_MODULE(dtlmod, m)
   engine.def_property_readonly("name", &Engine::get_name, "The name of the Engine (read-only)")
       .def("begin_transaction", &Engine::begin_transaction, py::call_guard<py::gil_scoped_release>(),
            "Begin a transaction on this Engine")
-      .def("put", py::overload_cast<std::shared_ptr<Variable>>(&Engine::put, py::const_), py::arg("var"),
+      .def("put", py::overload_cast<const std::shared_ptr<Variable>&>(&Engine::put, py::const_), py::arg("var"),
            py::call_guard<py::gil_scoped_release>(), "Put a Variable in the DTL using this Engine")
-      .def("put", py::overload_cast<std::shared_ptr<Variable>, size_t>(&Engine::put, py::const_), py::arg("var"),
+      .def("put", py::overload_cast<const std::shared_ptr<Variable>&, size_t>(&Engine::put, py::const_), py::arg("var"),
            py::arg("simulated_size_in_bytes"), py::call_guard<py::gil_scoped_release>(),
            "Put a Variable in the DTL using this Engine")
       .def("get", &Engine::get, py::arg("var"), py::call_guard<py::gil_scoped_release>(),
@@ -182,7 +182,7 @@ PYBIND11_MODULE(dtlmod, m)
       .def_property_readonly("current_transaction", &Engine::get_current_transaction,
                              "The id of the current transaction on this Engine (read-only)")
       .def_property_readonly("metadata_file_name", &Engine::get_metadata_file_name,
-           "The name of the file in which the engine stored metadata (read-only)")
+                             "The name of the file in which the engine stored metadata (read-only)")
       .def("close", &Engine::close, py::call_guard<py::gil_scoped_release>(), "Close this Engine");
 
   py::enum_<Engine::Type>(engine, "Type", "The type of Engine")