check and fix use of noexcept

Author: frs69wq

include/dtlmod/ActorRegistry.hpp

@@ -31,7 +31,7 @@ class ActorRegistry {
   ActorRegistry() = default;
 
   void add(sg4::ActorPtr actor) { actors_.insert(actor); }
-  void remove(sg4::ActorPtr actor) noexcept { actors_.erase(actor); }
+  void remove(sg4::ActorPtr actor) { actors_.erase(actor); }
   [[nodiscard]] bool contains(sg4::ActorPtr actor) const noexcept { return actors_.find(actor) != actors_.end(); }
   [[nodiscard]] size_t count() const noexcept { return actors_.size(); }
   [[nodiscard]] const std::set<sg4::ActorPtr>& get_actors() const noexcept { return actors_; }

include/dtlmod/DTL.hpp

@@ -28,8 +28,8 @@ class DTL {
 
 protected:
   /// \cond EXCLUDE_FROM_DOCUMENTATION
-  void lock() noexcept { mutex_->lock(); }
-  void unlock() noexcept { mutex_->unlock(); }
+  void lock() { mutex_->lock(); }
+  void unlock() { mutex_->unlock(); }
   /// \endcond
 
 public:

include/dtlmod/FileTransport.hpp

@@ -31,18 +31,18 @@ class FileTransport : public Transport {
   void close_pub_files() const;
   void close_sub_files(sg4::ActorPtr self);
   const std::vector<std::pair<std::shared_ptr<sgfs::File>, sg_size_t>>&
-  get_to_write_in_transaction_by_actor(sg4::ActorPtr actor) noexcept
+  get_to_write_in_transaction_by_actor(sg4::ActorPtr actor)
   {
     return to_write_in_transaction_[actor];
   }
-  void clear_to_write_in_transaction(sg4::ActorPtr actor) noexcept { to_write_in_transaction_[actor].clear(); }
+  void clear_to_write_in_transaction(sg4::ActorPtr actor) { to_write_in_transaction_[actor].clear(); }
 
   const std::vector<std::pair<std::shared_ptr<sgfs::File>, sg_size_t>>&
-  get_to_read_in_transaction_by_actor(sg4::ActorPtr actor) noexcept
+  get_to_read_in_transaction_by_actor(sg4::ActorPtr actor)
   {
     return to_read_in_transaction_[actor];
   }
-  void clear_to_read_in_transaction(sg4::ActorPtr actor) noexcept { to_read_in_transaction_[actor].clear(); }
+  void clear_to_read_in_transaction(sg4::ActorPtr actor) { to_read_in_transaction_[actor].clear(); }
 
 public:
   void put(const std::shared_ptr<Variable>& var, size_t size) override;

include/dtlmod/StagingTransport.hpp

@@ -26,12 +26,12 @@ class StagingTransport : public Transport {
 
   // Create a message queue to receive request for variable pieces from subscribers
   void set_publisher_put_requests_mq(const std::string& publisher_name);
-  [[nodiscard]] sg4::MessageQueue* get_publisher_put_requests_mq(const std::string& publisher_name) const noexcept;
-  [[nodiscard]] bool pending_put_requests_exist_for(const std::string& pub_name) noexcept
+  [[nodiscard]] sg4::MessageQueue* get_publisher_put_requests_mq(const std::string& publisher_name) const;
+  [[nodiscard]] bool pending_put_requests_exist_for(const std::string& pub_name)
   {
     return not pending_put_requests_[pub_name].empty();
   }
-  [[nodiscard]] sg4::ActivityPtr wait_any_pending_put_request_for(const std::string& pub_name) noexcept
+  [[nodiscard]] sg4::ActivityPtr wait_any_pending_put_request_for(const std::string& pub_name)
   {
     return pending_put_requests_[pub_name].wait_any();
   }

include/dtlmod/Stream.hpp

@@ -89,10 +89,10 @@ class Stream : public std::enable_shared_from_this<Stream> {
   [[nodiscard]] const char* get_cname() const noexcept { return name_.c_str(); }
   /// @brief Helper function to print out the Engine::Type of the Stream.
   /// @return The corresponding C-string
-  [[nodiscard]] const char* get_engine_type_str() const;
+  [[nodiscard]] const char* get_engine_type_str() const noexcept;
   /// @brief Helper function to print out the Transport::Method of the Stream.
   /// @return The corresponding C-string
-  [[nodiscard]] const char* get_transport_method_str() const;
+  [[nodiscard]] const char* get_transport_method_str() const noexcept;
   /// @brief Helper function to know the access Mode of the Stream.
   /// @return The corresponding Stream::Mode
   [[nodiscard]] Mode get_access_mode() const noexcept { return access_mode_; }
@@ -113,10 +113,10 @@ class Stream : public std::enable_shared_from_this<Stream> {
   Stream& set_transport_method(const Transport::Method& transport_method);
   /// @brief Stream configuration function: specify that metadata must be exported
   /// @return The calling Stream (enable method chaining).
-  Stream& set_metadata_export();
+  Stream& set_metadata_export() noexcept;
   /// @brief Stream configuration function: specify that metadata must not be exported
   /// @return The calling Stream (enable method chaining).
-  Stream& unset_metadata_export();
+  Stream& unset_metadata_export() noexcept;
   /// @brief Get the name of the file in which the stream stores metadata
   /// @return The name of the file.
   [[nodiscard]] const std::string& get_metadata_file_name() const noexcept { return metadata_file_; }
@@ -131,10 +131,10 @@ class Stream : public std::enable_shared_from_this<Stream> {
 
   /// @brief Helper function to obtain the number of actors connected to Stream in Mode::Publish.
   /// @return The number of publishers for that Stream.
-  [[nodiscard]] size_t get_num_publishers() const noexcept { return engine_->get_publishers().count(); }
+  [[nodiscard]] size_t get_num_publishers() const { return engine_->get_publishers().count(); }
   /// @brief Helper function to obtain the number of actors connected to Stream in Mode::Subscribe.
   /// @return The number of subscribers for that Stream.
-  [[nodiscard]] size_t get_num_subscribers() const noexcept { return engine_->get_subscribers().count(); }
+  [[nodiscard]] size_t get_num_subscribers() const { return engine_->get_subscribers().count(); }
 
   /******* Variable Factory *******/
 

src/StagingTransport.cpp

@@ -25,7 +25,7 @@ void StagingTransport::set_publisher_put_requests_mq(const std::string& publishe
   publisher_put_requests_mq_[publisher_name] = sg4::MessageQueue::by_name(publisher_name);
 }
 
-sg4::MessageQueue* StagingTransport::get_publisher_put_requests_mq(const std::string& publisher_name) const noexcept
+sg4::MessageQueue* StagingTransport::get_publisher_put_requests_mq(const std::string& publisher_name) const
 {
   return publisher_put_requests_mq_.at(publisher_name);
 }

src/Stream.cpp

@@ -18,7 +18,7 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(dtlmod_stream, dtlmod, "DTL logging about Stream
 
 namespace dtlmod {
 
-const char* Stream::get_engine_type_str() const
+const char* Stream::get_engine_type_str() const noexcept
 {
   const std::map<Engine::Type, const char*> EnumStrings{
       {Engine::Type::File, "Engine::Type::File"},
@@ -60,7 +60,7 @@ Stream& Stream::set_engine_type(const Engine::Type& engine_type)
   return *this;
 }
 
-const char* Stream::get_transport_method_str() const
+const char* Stream::get_transport_method_str() const noexcept
 {
   const std::map<Transport::Method, const char*> EnumStrings{
       {Transport::Method::File, "Transport::Method::File"},
@@ -104,12 +104,12 @@ Stream& Stream::set_transport_method(const Transport::Method& transport_method)
   return *this;
 }
 
-Stream& Stream::set_metadata_export()
+Stream& Stream::set_metadata_export() noexcept
 {
   metadata_export_ = true;
   return *this;
 }
-Stream& Stream::unset_metadata_export()
+Stream& Stream::unset_metadata_export() noexcept
 {
   metadata_export_ = false;
   return *this;