[Sonar] more issues fixed

Author: frs69wq

include/dtlmod/CompressionReductionMethod.hpp

@@ -61,7 +61,7 @@ class CompressionReductionMethod : public ReductionMethod {
   std::map<const Variable*, std::shared_ptr<ParameterizedCompression>> per_variable_parameterizations_;
 
   /// @brief Derive the compression ratio from accuracy and compressor profile.
-  static double derive_compression_ratio(double accuracy, const std::string& profile, double data_smoothness);
+  static double derive_compression_ratio(double accuracy, std::string_view profile, double data_smoothness);
 
 public:
   using ReductionMethod::ReductionMethod;

include/dtlmod/Variable.hpp

@@ -127,7 +127,7 @@ class Variable : public std::enable_shared_from_this<Variable> {
   /// @param method a ReductionMethod (already defined).
   /// @param paramaters specific parameters in key-value form to apply the reduction method to the Variable.
   void set_reduction_operation(std::shared_ptr<ReductionMethod> method,
-                               std::map<std::string, std::string, std::less<>> parameters);
+                               const std::map<std::string, std::string, std::less<>>& parameters);
 
   [[nodiscard]] bool is_reduced() const { return is_reduced_with_ != nullptr; }
 

src/CompressionReductionMethod.cpp

@@ -50,7 +50,7 @@ double CompressionReductionMethod::get_flop_amount_to_decompress_variable(const
   return param->get_decompression_cost_per_element() * num_elements;
 }
 
-double CompressionReductionMethod::derive_compression_ratio(double accuracy, const std::string& profile,
+double CompressionReductionMethod::derive_compression_ratio(double accuracy, std::string_view profile,
                                                             double data_smoothness)
 {
   if (profile == "sz") {

src/DecimationReductionMethod.cpp

@@ -134,10 +134,12 @@ void DecimationReductionMethod::reduce_variable(const Variable& var)
   auto stride           = parameterization->get_stride();
 
   std::vector<size_t> reduced_shape;
-  size_t i = 0;
-  for (auto dim_size : original_shape)
+  size_t idx = 0;
+  for (auto dim_size : original_shape) {
     reduced_shape.push_back(
-        static_cast<size_t>(std::ceil(static_cast<double>(dim_size) / static_cast<double>(stride[i++]))));
+        static_cast<size_t>(std::ceil(static_cast<double>(dim_size) / static_cast<double>(stride[idx]))));
+    idx++;
+  }
   parameterization->set_reduced_shape(reduced_shape);
 
   auto self           = sg4::Actor::self();
@@ -147,7 +149,7 @@ void DecimationReductionMethod::reduce_variable(const Variable& var)
 
   for (size_t i = 0; i < original_shape.size(); i++) {
     // Sanity checks that shape, start, and count have the same size have already been done
-    size_t r_start = static_cast<size_t>(std::ceil(static_cast<double>(start[i]) / static_cast<double>(stride[i])));
+    auto r_start = static_cast<size_t>(std::ceil(static_cast<double>(start[i]) / static_cast<double>(stride[i])));
     size_t r_next_start = std::min(
         original_shape[i],
         static_cast<size_t>(std::ceil(static_cast<double>(start[i] + count[i]) / static_cast<double>(stride[i]))));

src/Variable.cpp

@@ -60,7 +60,7 @@ void Variable::set_transaction_selection(unsigned int begin, unsigned int count)
 }
 
 void Variable::set_reduction_operation(std::shared_ptr<ReductionMethod> method,
-                                       std::map<std::string, std::string, std::less<>> parameters)
+                                       const std::map<std::string, std::string, std::less<>>& parameters)
 {
   auto stream = defined_in_stream_.lock();
   xbt_assert(stream, "Variable::set_reduction_operation called after its Stream has been destroyed");