[sonar] smells--

Author: frs69wq

include/dtlmod/ActorRegistry.hpp

@@ -31,18 +31,15 @@ class ActorRegistry {
   ActorRegistry() = default;
 
   void add(sg4::ActorPtr actor) { actors_.insert(actor); }
-
   void remove(sg4::ActorPtr actor) noexcept { actors_.erase(actor); }
-
   [[nodiscard]] bool contains(sg4::ActorPtr actor) const noexcept { return actors_.find(actor) != actors_.end(); }
-
   [[nodiscard]] size_t count() const noexcept { return actors_.size(); }
   [[nodiscard]] const std::set<sg4::ActorPtr>& get_all() const noexcept { return actors_; }
   [[nodiscard]] bool is_empty() const noexcept { return actors_.empty(); }
   [[nodiscard]] sg4::BarrierPtr get_or_create_barrier()
   {
     if (!barrier_)
-      barrier_ = sg4::Barrier::create(actors_.size());
+      barrier_ = sg4::Barrier::create(static_cast<unsigned int>(actors_.size()));
     return barrier_;
   }
   [[nodiscard]] bool is_last_at_barrier() { return barrier_ && barrier_->wait(); }

src/FileEngine.cpp

@@ -104,10 +104,8 @@ void FileEngine::end_pub_transaction()
   auto transport = std::static_pointer_cast<FileTransport>(transport_);
 
   // This is the end of the first transaction, create a barrier
-  auto pub_barrier = publishers_.get_or_create_barrier();
-  if (pub_barrier) {
+  if (auto pub_barrier = publishers_.get_or_create_barrier())
     XBT_DEBUG("Barrier created for %zu publishers", publishers_.count());
-  }
 
   // Publisher gets the list of files and size to write that has been build during the put() operations
   auto to_write = transport->get_to_write_in_transaction_by_actor(self);

src/StagingEngine.cpp

@@ -69,10 +69,8 @@ void StagingEngine::begin_pub_transaction()
 void StagingEngine::end_pub_transaction()
 {
   // This is the end of the first transaction, create a barrier
-  auto pub_barrier = publishers_.get_or_create_barrier();
-  if (pub_barrier) {
+  if (auto pub_barrier = publishers_.get_or_create_barrier())
     XBT_DEBUG("Barrier created for %zu publishers", publishers_.count());
-  }
 
   // A new pub transaction has been completed, notify subscribers that they can starting getting variables
   if (is_last_publisher() && (completed_pub_transaction_id_ < current_pub_transaction_id_)) {
@@ -149,10 +147,8 @@ void StagingEngine::begin_sub_transaction()
 void StagingEngine::end_sub_transaction()
 {
   // This is the end of the first transaction, create a barrier
-  auto sub_barrier = subscribers_.get_or_create_barrier();
-  if (sub_barrier) {
+  if (auto sub_barrier = subscribers_.get_or_create_barrier())
     XBT_DEBUG("Barrier created for %zu subscribers", subscribers_.count());
-  }
 
   if (subscribers_.is_last_at_barrier()) {
     XBT_DEBUG("Wait for the %d subscribe activities for the transaction", sub_transaction_.size());