remove unused function

Author: peterguy

internal/api/proxy.go

@@ -8,19 +8,6 @@ import (
 	"net/url"
 )
 
-// proxyDialAddr returns proxyURL.Host with a default port appended if one is
-// not already present (443 for https, 80 for http).
-func proxyDialAddr(proxyURL *url.URL) string {
-	// net.SplitHostPort returns an error when the input doesn't contain a port
-	if _, _, err := net.SplitHostPort(proxyURL.Host); err == nil {
-		return proxyURL.Host
-	}
-	if proxyURL.Scheme == "https" {
-		return net.JoinHostPort(proxyURL.Hostname(), "443")
-	}
-	return net.JoinHostPort(proxyURL.Hostname(), "80")
-}
-
 // withProxyTransport modifies the given transport to handle proxying of unix, socks5 and http connections.
 //
 // Note: baseTransport is considered to be a clone created with transport.Clone()

internal/api/proxy_test.go

@@ -397,37 +397,3 @@ func TestWithProxyTransport_ProxyRejectsConnect(t *testing.T) {
 		})
 	}
 }
-
-func TestProxyDialAddr(t *testing.T) {
-	tests := []struct {
-		name string
-		url  string
-		want string
-	}{
-		{"https with port", "https://proxy.example.com:8443", "proxy.example.com:8443"},
-		{"https without port", "https://proxy.example.com", "proxy.example.com:443"},
-		{"http with port", "http://proxy.example.com:8080", "proxy.example.com:8080"},
-		{"http without port", "http://proxy.example.com", "proxy.example.com:80"},
-		{"ipv4 with port", "http://192.168.1.100:3128", "192.168.1.100:3128"},
-		{"ipv4 without port https", "https://10.0.0.1", "10.0.0.1:443"},
-		{"ipv4 without port http", "http://172.16.0.5", "172.16.0.5:80"},
-		{"ipv6 with port", "http://[::1]:8080", "[::1]:8080"},
-		{"ipv6 without port https", "https://[2001:db8::1]", "[2001:db8::1]:443"},
-		{"ipv6 without port http", "http://[fe80::1]", "[fe80::1]:80"},
-		{"localhost with port", "http://localhost:9090", "localhost:9090"},
-		{"localhost without port https", "https://localhost", "localhost:443"},
-		{"localhost without port http", "http://localhost", "localhost:80"},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			u, err := url.ParseRequestURI(tt.url)
-			if err != nil {
-				t.Fatalf("parse URL: %v", err)
-			}
-			got := proxyDialAddr(u)
-			if got != tt.want {
-				t.Errorf("proxyHostPort(%s) = %q, want %q", tt.url, got, tt.want)
-			}
-		})
-	}
-}