deprecate redis errors param

Author: chillaq

splitio/client/config.py

@@ -171,7 +171,12 @@ def sanitize(sdk_key, config):
         processed["httpAuthenticateScheme"] = authenticate_scheme
 
     processed = _sanitize_fallback_config(config, processed)    
+    
+    if config.get("redisErrors") is not None:
+        _LOGGER.warning('Parameter `redisErrors` is deprecated as it is no longer supported in redis lib.' \
+                        ' Will ignore this value.')
 
+        processed["redisErrors"] = None
     return processed
 
 def _sanitize_fallback_config(config, processed):

splitio/storage/adapters/redis.py

@@ -715,7 +715,6 @@ def _build_default_client(config):  # pylint: disable=too-many-locals
     unix_socket_path = config.get('redisUnixSocketPath', None)
     encoding = config.get('redisEncoding', 'utf-8')
     encoding_errors = config.get('redisEncodingErrors', 'strict')
-#    errors = config.get('redisErrors', None)
     decode_responses = config.get('redisDecodeResponses', True)
     retry_on_timeout = config.get('redisRetryOnTimeout', False)
     ssl = config.get('redisSsl', False)

tests/client/test_factory.py

@@ -112,7 +112,6 @@ def test_redis_client_creation(self, mocker):
             'redisConnectionPool': False,
             'redisUnixSocketPath': '/some_path',
             'redisEncodingErrors': 'non-strict',
-            'redisErrors': True,
             'redisDecodeResponses': True,
             'redisRetryOnTimeout': True,
             'redisSsl': True,

tests/storage/adapters/test_redis_adapter.py

@@ -99,7 +99,6 @@ def test_adapter_building(self, mocker):
             'redisUnixSocketPath': '/tmp/socket',
             'redisEncoding': 'utf-8',
             'redisEncodingErrors': 'strict',
-#            'redisErrors': 'abc',
             'redisDecodeResponses': True,
             'redisRetryOnTimeout': True,
             'redisSsl': True,
@@ -151,7 +150,6 @@ def test_adapter_building(self, mocker):
             'redisUnixSocketPath': '/tmp/socket',
             'redisEncoding': 'utf-8',
             'redisEncodingErrors': 'strict',
-#            'redisErrors': 'abc',
             'redisDecodeResponses': True,
             'redisRetryOnTimeout': True,
             'redisSsl': False,
@@ -529,7 +527,6 @@ def master_for(se,
             'redisUnixSocketPath': '/tmp/socket',
             'redisEncoding': 'utf-8',
             'redisEncodingErrors': 'strict',
-            'redisErrors': 'abc',
             'redisDecodeResponses': True,
             'redisRetryOnTimeout': True,
             'redisSsl': False,