Struggling to upload the code...
--- a/stake/constant.py
+++ b/stake/constant.py
@@ -10,6 +10,7 @@ class NYSEUrl(BaseModel):
"""Contains all the visited stake urls for the NYSE."""

 STAKE_URL: str = "https://api2.prd.hellostake.com/"

STAKE_OVER_URL: str = "https://api.prd.hellostake.com/"
account_balance: str = urljoin(
STAKE_URL, "api/cma/getAccountBalance", allow_fragments=True
)
@@ -47,7 +48,7 @@ class NYSEUrl(BaseModel):
STAKE_URL, "api/purchaseorders/v2/quickBuy", allow_fragments=True
)
quotes: str = urljoin(

   STAKE_URL, "api/quotes/marketData/{symbols}", allow_fragments=True

```
   STAKE_OVER_URL, "us/pricing/quotes/marketData", allow_fragments=True
```
)
rate: str = urljoin(STAKE_URL, "api/wallet/rate", allow_fragments=True)
ratings: str = urljoin(
diff --git a/stake/product.py b/stake/product.py
index b6a5ab5..8803dee 100644
--- a/stake/product.py
+++ b/stake/product.py
@@ -6,13 +6,14 @@ from pydantic import BaseModel, ConfigDict, PrivateAttr
from pydantic.fields import Field

from stake.common import BaseClient, camelcase
+from stake.constant import NYSEUrl

if TYPE_CHECKING:
from stake.client import StakeClient
from stake.ratings import Rating
from stake.statement import Statement

-all = ["ProductSearchByName"]
+all = ["ProductSearchByName", "ProductQuote"]

class ProductSearchByName(BaseModel):
@@ -30,6 +31,27 @@ class Instrument(BaseModel):
model_config = ConfigDict(alias_generator=camelcase)

+class ProductQuote(BaseModel):

symbol: str
bid: Optional[float] = None
ask: Optional[float] = None
close: Optional[float] = None
close_bid: Optional[float] = None
close_ask: Optional[float] = None
last_trade: Optional[float] = None
pre_post_market_last_trade: Optional[float] = None
prior_close: Optional[float] = None
open: Optional[float] = None
high: Optional[float] = None
low: Optional[float] = None
market_status: Optional[str] = None
trading_status: Optional[str] = None
stake_instrument_id: Optional[uuid.UUID] = None
trade_timestamp: Optional[datetime] = None
volume: Optional[int] = None
model_config = ConfigDict(alias_generator=camelcase)

class Product(BaseModel):
id: uuid.UUID
instrument_type_id: Optional[str] = Field(None, alias="instrumentTypeID")
@@ -56,6 +78,22 @@ class Product(BaseModel):
trade_status: Optional[int] = None
encoded_name: str
period: str

bid: Optional[float] = None
ask: Optional[float] = None
close: Optional[float] = None
close_bid: Optional[float] = None
close_ask: Optional[float] = None
last_trade: Optional[float] = None
pre_post_market_last_trade: Optional[float] = None
prior_close: Optional[float] = None
open: Optional[float] = None
high: Optional[float] = None
low: Optional[float] = None
market_status: Optional[str] = None
trading_status: Optional[str] = None
stake_instrument_id: Optional[uuid.UUID] = None
trade_timestamp: Optional[datetime] = None
volume: Optional[int] = None
inception_date: Optional[datetime] = None
instrument_tags: List[Any]
child_instruments: List[Instrument]
@@ -84,6 +122,15 @@ class Product(BaseModel):

class ProductsClient(BaseClient):

async def quotes(self, symbols: List[str]) -> List[ProductQuote]:

   """Return market quote data for US symbols."""

   data = await self._client.post(self._client.exchange.quotes, {"symbols": symbols})

   return [ProductQuote.model_validate(quote) for quote in data]

async def quote(self, symbol: str) -> Optional[ProductQuote]:

   quotes = await self.quotes([symbol])

   return quotes[0] if quotes else None

async def get(self, symbol: str) -> Optional[Product]:
"""Given a symbol it will return the matching product.

@@ -94,13 +141,22 @@ class ProductsClient(BaseClient):
self._client.exchange.symbol.format(symbol=symbol)
)

```
   return (
```
```
       Product.model_validate(
```

           data["products"][0], context=dict(client=self._client)

```
       )
```
```
       if data["products"]
```
```
       else None
```
```
   )
```

```
   if not data["products"]:
```
```
       return None
```
```
   product_data = data["products"][0]
```

   if isinstance(self._client.exchange, NYSEUrl):

```
       try:
```

           quote = await self.quote(symbol)

```
       except Exception:
```
```
           quote = None
```
```
       if quote:
```
```
           product_data = {
```
```
               **product_data,
```

               **quote.model_dump(by_alias=True, exclude_none=True),

```
           }
```
```
   return Product.model_validate(product_data, context=dict(client=self._client))
```
async def search(self, request: ProductSearchByName) -> List[Instrument]:
products = await self._client.get(
diff --git a/tests/test_product.py b/tests/test_product.py
index 8ce4573..9667460 100644
--- a/tests/test_product.py
+++ b/tests/test_product.py
@@ -8,7 +8,7 @@ from pydantic import BaseModel
from stake import asx, constant
from stake.client import HttpClient, StakeClient
from stake.constant import NYSE
-from stake.product import Product
+from stake.product import Product, ProductsClient

@pytest.mark.parametrize("exchange", (constant.NYSE, constant.ASX))
@@ -45,6 +45,60 @@ async def test_product_serializer():
]

+@pytest.mark.asyncio
+async def test_get_us_product_adds_quote_bid_and_ask():

class Client:
```
   exchange = constant.NYSE
```
```
   async def get(self, url):
```
```
       return {
```
```
           "products": [
```
```
               {
```

                   "id": "16bf66e3-94f5-4357-88d0-48e2a44f44bf",

```
                   "symbol": "SE",
```

                   "description": "Sea Limited",

                   "urlImage": "https://example.com/se.png",

                   "name": "Sea Limited",

                   "dailyReturn": 1.75,

                   "dailyReturnPercentage": 2.01,

                   "lastTraded": 89.02,

```
                   "monthlyReturn": 0,
```
```
                   "popularity": 1,
```
```
                   "watched": 1,
```
```
                   "news": 0,
```
```
                   "bought": 1,
```
```
                   "viewed": 1,
```

                   "productType": "Instrument",

                   "encodedName": "sea-limited-se",

                   "period": "YEAR RETURN",

                   "instrumentTags": [],

                   "childInstruments": [],

```
               }
```
```
           ]
```
```
       }
```
```
   async def post(self, url, payload):
```

       assert url == constant.NYSE.quotes

       assert payload == {"symbols": ["SE"]}

```
       return [
```
```
           {
```
```
               "symbol": "SE",
```
```
               "bid": 88.5,
```
```
               "ask": 90,
```
```
               "lastTrade": 89.02,
```

               "marketStatus": "POSTMARKET",

```
           }
```
```
       ]
```
client = Client()
product = await ProductsClient(client).get("SE")
assert product.bid == 88.5
assert product.ask == 90
assert product.last_trade == 89.02
assert product.market_status == "POSTMARKET"

@pytest.mark.parametrize(
"exchange, symbols",
((constant.NYSE, ["TSLA", "MSFT", "GOOG"]), (constant.ASX, ["ANZ", "WDS", "COL"])),
(END)

Stake US Bid and Ask Prices Fix #178

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions