Chore(dom): DOM - helpers refactor (#165)

Author: SbsCruz

packages/dom/src/lib/ElementAssertion.ts

@@ -1,7 +1,9 @@
 import { Assertion, AssertionError } from "@assertive-ts/core";
 import equal from "fast-deep-equal";
 
-import { getExpectedAndReceivedStyles, getAccessibleDescription, isElementEmpty } from "./helpers/helpers";
+import { getAccessibleDescription } from "./helpers/accessibility";
+import { isElementEmpty } from "./helpers/dom";
+import { getExpectedAndReceivedStyles } from "./helpers/styles";
 
 export class ElementAssertion<T extends Element> extends Assertion<T> {
 

packages/dom/src/lib/helpers/accessibility.ts

@@ -0,0 +1,30 @@
+function normalizeText(text: string): string {
+  return text.replace(/\s+/g, " ").trim();
+}
+
+export function getAccessibleDescription(actual: Element): string {
+  const ariaDescribedBy = actual.getAttribute("aria-describedby");
+
+  if (!ariaDescribedBy) {
+    return "";
+  }
+
+  const descriptionIds = ariaDescribedBy.split(/\s+/).filter(Boolean);
+
+  const getElementText = (id: string): string | null => {
+    const element = actual.ownerDocument.getElementById(id);
+
+    if (!element || !element.textContent) {
+      return null;
+    }
+
+    return element.textContent;
+  };
+
+  const combinedText = descriptionIds
+    .map(getElementText)
+    .filter((text): text is string => text !== null)
+    .join(" ");
+
+  return normalizeText(combinedText);
+}

packages/dom/src/lib/helpers/dom.ts

@@ -0,0 +1,6 @@
+const COMMENT_NODE_TYPE = 8;
+
+export function isElementEmpty (element: Element): boolean {
+  const nonCommentChildNodes = [...element.childNodes].filter(child => child.nodeType !== COMMENT_NODE_TYPE);
+  return nonCommentChildNodes.length === 0;
+}

packages/dom/src/lib/helpers/helpers.ts packages/dom/src/lib/helpers/styles.tspackages/dom/src/lib/helpers/helpers.ts renamed to packages/dom/src/lib/helpers/styles.ts

@@ -3,8 +3,6 @@ interface StyleDeclaration extends Record<string, string> {
   value: string;
 }
 
-const COMMENT_NODE_TYPE = 8;
-
 function normalizeStyles(css: Partial<CSSStyleDeclaration>): StyleDeclaration {
   const normalizer = document.createElement("div");
   document.body.appendChild(normalizer);
@@ -75,39 +73,3 @@ export function getExpectedAndReceivedStyles
       elementProcessedStyle,
     ];
 }
-
-export function isElementEmpty (element: Element): boolean {
-  const nonCommentChildNodes = [...element.childNodes].filter(child => child.nodeType !== COMMENT_NODE_TYPE);
-  return nonCommentChildNodes.length === 0;
-}
-
-function normalizeText(text: string): string {
-  return text.replace(/\s+/g, " ").trim();
-}
-
-export function getAccessibleDescription(actual: Element): string {
-  const ariaDescribedBy = actual.getAttribute("aria-describedby");
-
-  if (!ariaDescribedBy) {
-    return "";
-  }
-
-  const descriptionIds = ariaDescribedBy.split(/\s+/).filter(Boolean);
-
-  const getElementText = (id: string): string | null => {
-    const element = actual.ownerDocument.getElementById(id);
-
-    if (!element || !element.textContent) {
-      return null;
-    }
-
-    return element.textContent;
-  };
-
-  const combinedText = descriptionIds
-    .map(getElementText)
-    .filter((text): text is string => text !== null)
-    .join(" ");
-
-  return normalizeText(combinedText);
-}