view-uplift-phase-02 (#637)

Summary:

- Amedned prepared statement argument miscount.
- Supports 3 way indirect join.  Ie: `view`, `materialized view`, suquery, user space table.
- Added robot test `Three Way View Subquery Provider Table Join Returns Results`.

Author: general-kroll-4-life

docs/data_flow.md

@@ -1,36 +1,36 @@
 
 # Data flow analysis in stackql
 
-Data flow analysis is impplmented as multiple passes on:
+Data flow analysis is implemented as multiple passes on:
 
-- An inital abstract syntax tree (AST) from the parser.
+- An initial abstract syntax tree (AST) from the parser.
    - Annotated derivatives of the AST.
 - `any-sdk`  `{ provider, service, resource, method, schema... }` graphs.
 - `gonum` DAG adaptations with data flow dependencies representing edges.
 
 Some other aspects of data flow analysis:
 
 - Relational algebra is implemented in a coupled RDBMS (embedded `sqlite` or `postgres` over TCP).  There is a query rewriting process to stringify "containers" for this.
-- There are `transaction control counter` objects and corresponding RDBMS columns to bound relational algebra "containers" and future proof for gargage collection.  Some mutex protection is in place.
+- There are `transaction control counter` objects and corresponding RDBMS columns to bound relational algebra "containers" and future proof for garbage collection.  Some mutex protection is in place.
 - Views in `stackql` permit clobbering of where clause arguments from outside the view.  The canonical case is a document-based view in a provider document.  A good example are in [test/registry/src/aws/v0.1.0/services/pseudo_s3.yaml](/test/registry/src/aws/v0.1.0/services/pseudo_s3.yaml)at `...s3_bucket_list_and_detail.config.views.select`; one can overwrite `region` here.
 - Views, subqueries, materialized views and user space tables are modelled as "indirections".
 
 
-## Open Issues
+## Reasonable expectations
 
 ## Indirection Data Flow Analysis and Query Execution
 
-Data flow analysis for indirections is not composable:
+Data flow analysis for indirections ought to be composable:
 
-- It it impossible to join heterogenous collections of these with each other or conventional resources.  There is no recusrsive and stable data flow analysis.
-- While `stackql` does have a `max depth` parameter, I do not believe it is stable enfoced eagerly.  Ie: queries too complex should fail at analysis time.  Cannot remember param name of=r default.
+- It should be possible to join heterogeneous collections of these with each other or conventional resources.  There should exist recursive and stable data flow analysis.
+- `stackql`'s `max depth` parameter should be stably enforced, eagerly.  Ie: queries too complex should fail at analysis time.
 
-The expected fix for this issue:
+In other words, the expected behaviour:
 
 - Joins, unions etc on indirections work to arbitrary and configurable depth.  For depth violations, failure is eager in the analysis phase and error message is plain and in the canonical err stream already widely used.
-- Data flow analysis includes assurance on reuired poarams and viability of projections, joins, etc.
+- Data flow analysis includes assurance on required params and viability of projections, joins, etc.
 - Support for CTEs internal to these indirections is in place.
-- Mocked robot tests are added to the canonical test suite, covering off this function.
+- Mocked robot tests are included in the canonical test suite, covering off this function.
 
 
 ## Glossary of terms

docs/views.md

@@ -68,7 +68,6 @@ Views are rendered as inline subqueries `( SELECT ... ) AS "alias"` in the final
 
 **Not supported:**
 - Table-qualified parameter clobbering into views (e.g. `WHERE v1.region = 'us-east-1'` will not override the view's internal `region` parameter).
-- Joins of three or more heterogeneous indirections (e.g. `view JOIN subquery JOIN provider_table`).  Binary joins work; three-way and beyond fail with parameter count mismatches in the SQL composition layer.
 
 ### Materialized views (eager evaluated)
 

internal/stackql/drm/prepared_statement_args.go

@@ -81,9 +81,8 @@ func (ca *standardPreparedStatementArgs) Analyze() error {
 
 func (ca *standardPreparedStatementArgs) compose() (childQueryComposition, error) {
 	var varArgs []interface{}
-	j := 0
 	query := ca.GetQuery()
-	var childQueryStrings []interface{} // dunno why
+	var childQueryStrings []interface{}
 	var keys []int
 	for i := range ca.GetChildren() {
 		keys = append(keys, i)
@@ -97,14 +96,11 @@ func (ca *standardPreparedStatementArgs) compose() (childQueryComposition, error
 		}
 		childQueryStrings = append(childQueryStrings, childResponse.GetQueryString())
 		varArgs = append(varArgs, childResponse.GetVarArgs()...)
-		j = k
 	}
 	if len(childQueryStrings) > 0 {
 		query = fmt.Sprintf(ca.GetQuery(), childQueryStrings...)
 	}
-	if len(ca.GetArgs()) >= j {
-		varArgs = append(varArgs, ca.GetArgs()[j:]...)
-	}
+	varArgs = append(varArgs, ca.GetArgs()...)
 	return newChildQueryComposition(query, varArgs), nil
 }
 

test/robot/functional/stackql_mocked_from_cmd_line.robot

@@ -9580,6 +9580,23 @@ View JOIN Materialized View Returns Results
     ...    stdout=${CURDIR}/tmp/View-JOIN-Materialized-View-Returns-Results-stdout.tmp
     ...    stderr=${CURDIR}/tmp/View-JOIN-Materialized-View-Returns-Results-stderr.tmp
 
+Three Way View Subquery Provider Table Join Returns Results
+    ${inputStr} =    Catenate
+    ...    create or replace view vw_repos as select name, url from stackql_repositories;
+    ...    select v1.name from vw_repos v1 inner join (select name from stackql_repositories) sq on v1.name = sq.name inner join github.repos.repos r on v1.name = r.name where r.org = 'stackql';
+    Should Stackql Exec Inline Contain
+    ...    ${STACKQL_EXE}
+    ...    ${OKTA_SECRET_STR}
+    ...    ${GITHUB_SECRET_STR}
+    ...    ${K8S_SECRET_STR}
+    ...    ${REGISTRY_NO_VERIFY_CFG_STR}
+    ...    ${AUTH_CFG_STR}
+    ...    ${SQL_BACKEND_CFG_STR_CANONICAL}
+    ...    ${inputStr}
+    ...    dummyapp.io
+    ...    stdout=${CURDIR}/tmp/Three-Way-View-Subquery-Provider-Table-Join-Returns-Results-stdout.tmp
+    ...    stderr=${CURDIR}/tmp/Three-Way-View-Subquery-Provider-Table-Join-Returns-Results-stderr.tmp
+
 CTE Within View Returns Results
     ${inputStr} =    Catenate
     ...    create or replace view vw_cte as with sub as (select name from stackql_repositories) select name from sub;