Skip to content

Commit f290b60

Browse files
linter-fixes
1 parent cee8782 commit f290b60

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

internal/stackql/dependencyplanner/dependencyplanner.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ func isAnnotationIndirection(annotationCtx taxonomy.AnnotationCtx) bool {
115115
// This method creates a NopBuilder as a placeholder in the execution DAG.
116116
// Indirections are NOT added to dp.tableSlice because they appear as inline subqueries
117117
// with their own internal control columns; adding them would generate incorrect outer WHERE clauses.
118+
//
119+
//nolint:unparam,revive // acceptable
118120
func (dp *standardDependencyPlanner) orchestrateIndirection(
119121
annotationCtx taxonomy.AnnotationCtx,
120122
) (int, error) {
@@ -258,6 +260,7 @@ func (dp *standardDependencyPlanner) Plan() error {
258260
continue
259261
}
260262
for _, e := range edges {
263+
//nolint:nestif // necessary to handle indirection cases cleanly
261264
if e.From().ID() == n.ID() {
262265
insPsc, tcc, insErr := dp.processOrphan(tableExpr, annotation, n)
263266
if insErr != nil {
@@ -317,6 +320,7 @@ func (dp *standardDependencyPlanner) Plan() error {
317320
}
318321
continue
319322
}
323+
//nolint:nestif // necessary to handle indirection cases cleanly
320324
if fromIsIndirection {
321325
// Source is indirection, destination is a regular table.
322326
fromIdx := dp.nodeIDIdxMap[fromNode.ID()]
@@ -343,6 +347,7 @@ func (dp *standardDependencyPlanner) Plan() error {
343347
}
344348
continue
345349
}
350+
//nolint:nestif // necessary to handle indirection cases cleanly
346351
if toIsIndirection {
347352
// Destination is indirection, source is a regular table.
348353
toIdx := dp.nodeIDIdxMap[toNode.ID()]

0 commit comments

Comments
 (0)