Feature/improve flashblocks test framework#3
Open
maoueh wants to merge 5 commits into
Open
Conversation
…mework
Introduces TestEvent{Flashblock, CanonicalBlock} to replace raw Vec<Flashblock>
in run_flashblock_sequence. CanonicalBlock events update GenesisClient's internal
available-block set so state_by_block_number_or_tag returns successfully for that
block number without WS traffic. Adds two new tests covering the provider bootstrap
path; all 12 integration tests pass.
# Conflicts:
# crates/firehose-flashblocks/tests/flashblock_sequence.rs
…_block return TestEvent directly - flash_base and flash_delta now return TestEvent instead of Flashblock, eliminating the need for TestEvent::flashblock(...) wrapping at call sites. - Add a module-level canonical_block free function mirroring flash_base and flash_delta, so all three helpers are uniform. - Add #[derive(Clone)] to TestEvent to support cloning in duplicate-base test. - Remove the now-unused TestEvent::canonical_block method and the unwrap_flashblock internal helper (the run_flashblock_sequence split loop is self-contained). - Rename all delta local variables throughout flashblock_sequence.rs to follow the delta<blockNum>_<flashIndex> convention (e.g. delta1_1, delta1_2, delta2_1). - Rename base local variables to base1, base2, etc. for consistency. - Update module-level doc comment to reflect the new helper signatures. # Conflicts: # crates/firehose-flashblocks/tests/flashblock_sequence.rs
maoueh
force-pushed
the
feature/improve-flashblocks-test-framework
branch
from
959fa49 to
6aa7496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.