Membership check happens only once

[AnotherMatt92]

If a member leaves they get a member check email
If they join again and stop for a second time they do not get a new membercheck email
There is a flag or similar in the code to make sure this email is only sent once, but this should be reset if membership starts back up again
Does this affect any other emails sent too?

[AnotherMatt92]

It appears that when the function send_reminder_email (lib/AccessSystem/API/Controller/Root.pm line 980) is checks all previous emails sent to the member to see if one is called 'reminder_email' if its there then it will never send an other one.

Is it possible that when we sent the rejoin_payment (lib/AccessSystem/Schema/Result/Person.pm line 540 that we remove the email name from emails set.

Or a better way might be to check if a rejoin_email has been sent more recently than the reminder_email - if so then its ok to send another reminder email as this is the second time (or more) that they have stopped their membership

[AnotherMatt92]

Something like this could be a possible fix in the root.pm line 980 - take with pinch of salt as this is AI generated and needs to be tested properly

my $comms_type = 'reminder_email';
my $member = $c->stash->{member};

if (my $comms = $member->communications_rs->search_rs({ type => $comms_type })->first) {
if ($comms->sent_on < $member->valid_date) {
$c->stash->{message} = 'Already reminded on ' . $comms->sent_on->iso8601();
return;
}
}