fix: community browse fetches members from network, not local DHT

dht_find_value_iterative short-circuited on the local CommunityMembers
entry which only contained the local node.  The relay's merged list
(with all members) was never queried, so remote shares never appeared.

- Extract dht_find_value_from_network (skips local cache, always queries peers)
- browse_community uses network lookup to get the relay's merged member list
- Filter own address from DHT-discovered members to avoid self-queries
- Local participant label changed from IP to 'this node'

Author: techartdev

Cargo.toml

@@ -11,7 +11,7 @@ resolver = "2"
 [workspace.package]
 edition = "2024"
 license = "MPL-2.0"
-version = "0.3.1"
+version = "0.3.2"
 repository = "https://github.com/techartdev/scp2p"
 
 [workspace.dependencies]

app/package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "scp2p-app",
   "private": true,
-  "version": "0.3.1",
+  "version": "0.3.2",
   "type": "module",
   "scripts": {
     "dev": "vite",

app/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://raw.githubusercontent.com/nicegui/nicegui/main/nicegui/static/tauri/schemas/tauri-conf-v2.json",
   "productName": "SCP2P",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "identifier": "com.scp2p.desktop",
   "build": {
     "frontendDist": "../dist",

app/src-tauri/tauri.conf.json

@@ -15,7 +15,7 @@ clap = { workspace = true, features = ["env"] }
 ed25519-dalek.workspace = true
 hex.workspace = true
 rand.workspace = true
-scp2p-core = { path = "../scp2p-core", version = "0.3.1" }
+scp2p-core = { path = "../scp2p-core", version = "0.3.2" }
 tokio.workspace = true
 inquire = "0.7"
 indicatif = "0.17"

crates/scp2p-cli/Cargo.toml

@@ -225,6 +225,25 @@ impl NodeHandle {
             return Ok(Some(value));
         }
 
+        self.dht_find_value_from_network(transport, key, seed_peers)
+            .await
+    }
+
+    /// Like [`Self::dht_find_value_iterative`], but always queries the
+    /// network even when a local copy exists.  The remote result is
+    /// stored locally before being returned.
+    ///
+    /// Use this for values where the relay's copy is the authoritative
+    /// merged superset (e.g. `CommunityMembers`).
+    pub async fn dht_find_value_from_network<T: RequestTransport + ?Sized>(
+        &self,
+        transport: &T,
+        key: [u8; 32],
+        seed_peers: &[PeerAddr],
+    ) -> anyhow::Result<Option<DhtValue>> {
+        let key_hex = hex::encode(&key[..8]);
+        debug!(key = %key_hex, "dht_find_value_from_network: starting");
+
         let mut target = [0u8; 20];
         target.copy_from_slice(&key[..20]);
         let mut peers = self
@@ -264,7 +283,7 @@ impl NodeHandle {
                         remote.ttl_secs.max(DEFAULT_TTL_SECS),
                         now,
                     )?;
-                    debug!(key = %key_hex, "dht_find_value_iterative: found remotely");
+                    debug!(key = %key_hex, "dht_find_value_from_network: found remotely");
                     return Ok(state.dht.find_value(key, now));
                 }
                 discovered |= merge_peer_list(&mut peers, result.closer_peers);
@@ -274,7 +293,7 @@ impl NodeHandle {
             }
         }
 
-        debug!(key = %key_hex, queried = queried.len(), "dht_find_value_iterative: not found");
+        debug!(key = %key_hex, queried = queried.len(), "dht_find_value_from_network: not found");
         Ok(None)
     }
 

crates/scp2p-core/src/api/node_dht.rs

@@ -4979,7 +4979,11 @@ async fn community_members_dht_merge_on_store() {
     let found = handle.dht_find_value(key).await.expect("find").unwrap();
     let merged: crate::wire::CommunityMembers =
         crate::cbor::from_slice(&found.value).expect("decode");
-    assert_eq!(merged.members.len(), 2, "should have both members after merge");
+    assert_eq!(
+        merged.members.len(),
+        2,
+        "should have both members after merge"
+    );
     assert!(merged.members.contains(&addr_a));
     assert!(merged.members.contains(&addr_b));
     assert_eq!(merged.updated_at, 200, "updated_at should be max of both");
@@ -5007,8 +5011,7 @@ async fn upsert_community_member_roundtrip() {
 
     let key = crate::dht_keys::community_info_key(&community_share_id);
     let found = handle.dht_find_value(key).await.expect("find").unwrap();
-    let cm: crate::wire::CommunityMembers =
-        crate::cbor::from_slice(&found.value).expect("decode");
+    let cm: crate::wire::CommunityMembers = crate::cbor::from_slice(&found.value).expect("decode");
     assert_eq!(cm.members.len(), 1);
     assert_eq!(cm.members[0], addr);
 

crates/scp2p-core/src/api/tests.rs

@@ -12,6 +12,6 @@ hex.workspace = true
 rand.workspace = true
 serde.workspace = true
 ciborium.workspace = true
-scp2p-core = { path = "../scp2p-core", version = "0.3.1" }
+scp2p-core = { path = "../scp2p-core", version = "0.3.2" }
 tokio.workspace = true
 tracing.workspace = true

crates/scp2p-desktop/Cargo.toml

@@ -675,15 +675,25 @@ impl DesktopAppState {
         // announced themselves as community members.  This is essential
         // because the bootstrap relay typically has NOT joined the
         // community, so without DHT discovery we'd return 0 participants.
+        //
+        // Use `dht_find_value_from_network` (not `_iterative`) because
+        // the local DHT copy only contains *this* node; the relay's
+        // copy is the merged superset of all members.
         let community_key =
             scp2p_core::community_info_key(&scp2p_core::ShareId(community.share_id));
+        let self_addr = self.resolve_self_addr(&node).await.ok();
         if let Ok(Some(dht_value)) = node
-            .dht_find_value_iterative(&transport, community_key, &peers)
+            .dht_find_value_from_network(&transport, community_key, &peers)
             .await
             && let Ok(cm) =
                 scp2p_core::cbor::from_slice::<scp2p_core::wire::CommunityMembers>(&dht_value.value)
         {
             for member in cm.members {
+                // Skip our own address — we already handle local shares
+                // separately below.
+                if self_addr.as_ref().is_some_and(|sa| member == *sa) {
+                    continue;
+                }
                 if !peers.iter().any(|p| p == &member) {
                     peers.push(member);
                 }
@@ -719,21 +729,17 @@ impl DesktopAppState {
                 )
                 .await
                 .unwrap_or_default();
+            let local_label = "this node".to_string();
             if !local_shares.is_empty() {
-                let self_addr_label = if let Ok(sa) = self.resolve_self_addr(&node).await {
-                    format!("{}:{}", sa.ip, sa.port)
-                } else {
-                    "local".to_string()
-                };
                 participants.push(CommunityParticipantView {
                     community_share_id_hex: hex::encode(community.share_id),
-                    peer_addr: self_addr_label.clone(),
+                    peer_addr: local_label.clone(),
                     transport: "local".to_string(),
                 });
                 for share in local_shares {
                     if seen_shares.insert(share.share_id) {
                         public_shares.push(PublicShareView {
-                            source_peer_addr: self_addr_label.clone(),
+                            source_peer_addr: local_label.clone(),
                             share_id_hex: hex::encode(share.share_id),
                             share_pubkey_hex: hex::encode(share.share_pubkey),
                             latest_seq: share.latest_seq,
@@ -746,6 +752,11 @@ impl DesktopAppState {
         }
 
         for peer in peers {
+            // Skip querying ourselves — local shares are already
+            // included above.
+            if self_addr.as_ref().is_some_and(|sa| peer == *sa) {
+                continue;
+            }
             match node
                 .fetch_community_status_from_peer(
                     &transport,

crates/scp2p-desktop/src/app_state.rs

@@ -14,7 +14,7 @@ name = "scp2p-relay"
 path = "src/main.rs"
 
 [dependencies]
-scp2p-core     = { path = "../scp2p-core", version = "0.3.1" }
+scp2p-core     = { path = "../scp2p-core", version = "0.3.2" }
 
 anyhow         = { workspace = true }
 async-trait    = { workspace = true }