-
Notifications
You must be signed in to change notification settings - Fork 0
Centralize discovery/scheduler warnings + add config option #75
Copy link
Copy link
Open
Labels
area: discoverycrates/tryke_discovery — AST parsing, test/fixture discoverycrates/tryke_discovery — AST parsing, test/fixture discoveryarea: runnercrates/tryke_runner — worker pool, schedulingcrates/tryke_runner — worker pool, schedulinggood first issueGood for newcomersGood for newcomershelp wantedContributions especially welcomeContributions especially welcomeinternalRefactor or cleanup with no user-visible behavior changeRefactor or cleanup with no user-visible behavior changerustPull requests that update rust codePull requests that update rust code
Description
Metadata
Metadata
Assignees
Labels
area: discoverycrates/tryke_discovery — AST parsing, test/fixture discoverycrates/tryke_discovery — AST parsing, test/fixture discoveryarea: runnercrates/tryke_runner — worker pool, schedulingcrates/tryke_runner — worker pool, schedulinggood first issueGood for newcomersGood for newcomershelp wantedContributions especially welcomeContributions especially welcomeinternalRefactor or cleanup with no user-visible behavior changeRefactor or cleanup with no user-visible behavior changerustPull requests that update rust codePull requests that update rust code
There are a few discovery and scheduling-related warnings that are being emitted from different places right now:
tryke/crates/tryke_runner/src/schedule.rs
Line 131 in dec570d
The reporter trait has a
on_discovery_warningfunctionI think for now it makes sense to just have the scheduler warnings use
on_discovery_warningso we have a single code path for these general types of warningsOnce that is done, that allows us to add config or a CLI option to quiet these warnings, either in the same batch of work or a follow on issue