Merge pull request #2582 from jku/more-flake-linters

Enable more linters (flake8-bugbear and flake8-datetimez)

Author: Lukas Pühringer

pyproject.toml

@@ -82,13 +82,15 @@ line-length=80
 
 [tool.ruff.lint]
 select = [
-    "D",  # pydocstyle
-    "E",  # pycodestyle
-    "F",  # pyflakes
-    "I",  # isort
-    "N",  # pep8-naming
-    "PL", # pylint
-    "S",  # flake8-bandit
+    "B",   # flake8-bugbear
+    "D",   # pydocstyle
+    "DTZ", # flake8-datetimez
+    "E",   # pycodestyle
+    "F",   # pyflakes
+    "I",   # isort
+    "N",   # pep8-naming
+    "PL",  # pylint
+    "S",   # flake8-bandit
 ] 
 ignore = ["D400","D415","D213","D205","D202","D107","D407","D413","D212","D104","D406","D105","D411","D401","D200","D203", "PLR0913", "PLR2004"]
 

tuf/api/_payload.py

@@ -181,8 +181,9 @@ def _common_fields_from_dict(
         # Convert 'expires' TUF metadata string to a datetime object, which is
         # what the constructor expects and what we store. The inverse operation
         # is implemented in '_common_fields_to_dict'.
-        expires = datetime.strptime(expires_str, "%Y-%m-%dT%H:%M:%SZ")
-        expires = expires.replace(tzinfo=timezone.utc)
+        expires = datetime.strptime(expires_str, "%Y-%m-%dT%H:%M:%SZ").replace(
+            tzinfo=timezone.utc
+        )
 
         return version, spec_version, expires
 

tuf/ngclient/_internal/requests_fetcher.py

@@ -94,7 +94,7 @@ def _fetch(self, url: str) -> Iterator[bytes]:
         except requests.HTTPError as e:
             response.close()
             status = e.response.status_code
-            raise exceptions.DownloadHTTPError(str(e), status)
+            raise exceptions.DownloadHTTPError(str(e), status) from e
 
         return self._chunks(response)
 

tuf/ngclient/updater.py

@@ -397,7 +397,7 @@ def _load_targets(self, role: str, parent_role: str) -> Targets:
             if metainfo is None:
                 raise exceptions.RepositoryError(
                     f"Role {role} was delegated but is not part of snapshot"
-                )
+                ) from None
 
             length = metainfo.length or self.config.targets_max_length
             version = None