Skip to content

Commit 96232d2

Browse files
author
Jussi Kukkonen
committed
verify_release: Tweak pip download
It seems --no-deps does not work as it used to (and actually installs all build dependencies). This is very bad because verify_release also uses "--no-binary :all:" leading to actually _building_ all build dependencies from source. Use "--no-binary tuf" instead: build dependencies will still be installed (into a working environment) but at least they won't be built from source. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
1 parent 3f28d40 commit 96232d2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

verify_release

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def get_pypi_pip_version() -> str:
7676
# newest tarball and figure out the version from the filename
7777
with TemporaryDirectory() as pypi_dir:
7878
cmd = ["pip", "download", "--no-deps", "--dest", pypi_dir]
79-
source_download = cmd + ["--no-binary", ":all:", PYPI_PROJECT]
79+
source_download = cmd + ["--no-binary", PYPI_PROJECT, PYPI_PROJECT]
8080
subprocess.run(source_download, stdout=subprocess.DEVNULL, check=True)
8181
for filename in os.listdir(pypi_dir):
8282
prefix, postfix = f"{PYPI_PROJECT}-", ".tar.gz"
@@ -113,7 +113,7 @@ def verify_pypi_release(version: str, compare_dir: str) -> bool:
113113
cmd = ["pip", "download", "--no-deps", "--dest", pypi_dir]
114114
target = f"{PYPI_PROJECT}=={version}"
115115
binary_download = cmd + [target]
116-
source_download = cmd + ["--no-binary", ":all:", target]
116+
source_download = cmd + ["--no-binary", PYPI_PROJECT, target]
117117

118118
subprocess.run(binary_download, stdout=subprocess.DEVNULL, check=True)
119119
subprocess.run(source_download, stdout=subprocess.DEVNULL, check=True)

0 commit comments

Comments
 (0)