lint: Enable flake8-self

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

Author: jku

examples/uploader/_localrepo.py

@@ -62,11 +62,12 @@ def open(self, role: str) -> Metadata:
 
         # if there is a metadata version fetched from remote, use that
         # HACK: access Updater internals
-        if role in self.updater._trusted_set:
+        trusted_set = self.updater._trusted_set  # noqa: SLF001
+        if role in trusted_set:
             # NOTE: The original signature wrapper (Metadata) was verified and
             # discarded upon inclusion in the trusted set. It is safe to use
             # a fresh wrapper. `close` will override existing signatures anyway.
-            return Metadata(copy.deepcopy(self.updater._trusted_set[role]))
+            return Metadata(copy.deepcopy(trusted_set[role]))
 
         # otherwise we're creating metadata from scratch
         md = Metadata(Targets())

pyproject.toml

@@ -104,6 +104,7 @@ select = [
     "RUF", # ruff-specific rules
     "S",   # flake8-bandit
     "SIM", # flake8-simplify
+    "SLF", # flake8-self
     "UP",  # pyupgrade
     "W",   # pycodestyle-warning
 ] 
@@ -117,8 +118,9 @@ ignore = [
 "tests/*" = [
     "D",      # pydocstyle: no docstrings required for tests
     "E501",   # line-too-long: embedded test data in "fmt: off" blocks is ok
-    "S",      # bandit: Not running bandit on tests
     "RUF012", # ruff: mutable-class-default
+    "S",      # bandit: Not running bandit on tests
+    "SLF001"  # private member access is ok in tests
 ]
 "examples/*/*" = [
     "D", # pydocstyle: no docstrings required for examples

tuf/ngclient/_internal/trusted_metadata_set.py

@@ -490,9 +490,9 @@ def _load_from_simple_envelope(
 
     envelope = SimpleEnvelope[T].from_bytes(data)
 
-    if envelope.payload_type != SimpleEnvelope._DEFAULT_PAYLOAD_TYPE:
+    if envelope.payload_type != SimpleEnvelope._DEFAULT_PAYLOAD_TYPE:  # noqa: SLF001
         raise exceptions.RepositoryError(
-            f"Expected '{SimpleEnvelope._DEFAULT_PAYLOAD_TYPE}', "
+            f"Expected '{SimpleEnvelope._DEFAULT_PAYLOAD_TYPE}', "  # noqa: SLF001
             f"got '{envelope.payload_type}'"
         )