Skip to content

Commit eb23fff

Browse files
author
Jussi Kukkonen
committed
lint: Stop using requests annotations
requests project does not maintain annotations: typeshed project tries to do it for them, and releases the annotations as "types-requests". There's two main problems: * typeshed releases constantly: this means a lot of test dependency updates * typeshed releases are not tagged in git: updates are impossible to review The benefit we get from types-requests is minimal as there is very little requests-related code and it does not change often. Remove annotations to lower the test dependency update churn. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
1 parent 83f2eee commit eb23fff

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ disable_error_code = ["attr-defined"]
149149

150150
[[tool.mypy.overrides]]
151151
module = [
152+
"requests.*",
152153
"securesystemslib.*",
153154
"urllib3.*"
154155
]

requirements-test.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ isort==5.10.1
1010
pylint==2.13.7
1111
mypy==0.942
1212
bandit==1.7.4
13-
types-requests==2.27.20

0 commit comments

Comments
 (0)