chore: cleanup and comments

Author: Jan Kaiser

angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

@@ -1,5 +1,4 @@
 import { Component, Input } from '@angular/core';
-import { Issue } from 'src/app/repository/services/repository.interfaces';
 import { RepoIssues } from 'src/app/state/repository';
 
 @Component({

angular-ngrx-scss/src/app/issues/components/issues.component.ts

@@ -1,4 +1,4 @@
-import { Component } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 import { Store } from '@ngrx/store';
 import {
@@ -15,7 +15,7 @@ import {
   templateUrl: './issues.component.html',
   styleUrls: ['./issues.component.scss'],
 })
-export class IssuesComponent {
+export class IssuesComponent implements OnInit {
   owner!: string;
   repoName!: string;
   openIssues$ = this.store.select(selectOpenIssues);

angular-ngrx-scss/src/app/repository/components/repo-header/repo-header.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input } from '@angular/core';
+import { Component } from '@angular/core';
 import { Store } from '@ngrx/store';
 import { selectedRepository } from 'src/app/state/repository';
 

angular-ngrx-scss/src/app/repository/services/repository.service.spec.ts

@@ -10,7 +10,6 @@ import {
   PullRequestAPIResponse,
   RepoApiResponse,
   RepoContentsApiResponse,
-  RepoIssues,
 } from 'src/app/state/repository';
 import {
   IssueComments,

angular-ngrx-scss/src/app/repository/services/repository.service.ts

@@ -1,4 +1,4 @@
-import { HttpClient, HttpParams, HttpResponse } from '@angular/common/http';
+import { HttpClient, HttpParams } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 import { Observable, forkJoin, map } from 'rxjs';
 import {
@@ -16,7 +16,6 @@ import { environment } from 'src/environments/environment';
 import {
   Issue,
   IssueComments,
-  Issues,
   PullRequest,
   PullRequests,
   RepositoryIssuesApiParams,
@@ -210,6 +209,11 @@ export class RepositoryService {
     const name = encodeURIComponent(repoName);
     const url = `${environment.githubUrl}/repos/${owner}/${name}/issues`;
 
+    // We need to make two calls to get the total count of issues and the issues themselves.
+    // This workaround is needed because the GitHub REST API doesn't return the total count of issues in the response.
+    // We can get the total count from the "Link" HTTP header,
+    // but we need to make a call with per_page=1 to be able to calculate the total count.
+    // See https://developer.github.com/v3/guides/traversing-with-pagination/#calculating-the-pagination-offset
     return forkJoin([
       this.http.get(url, {
         observe: 'response',

angular-ngrx-scss/src/app/shared/components/pagination/pagination.component.ts

@@ -15,7 +15,6 @@ export class PaginationComponent {
 
   @Input() set params(params: PaginationParams | null | undefined) {
     if (params) {
-      console.log(params);
       this.paginationParams = params;
     }
   }

angular-ngrx-scss/src/app/state/repository/repository.effects.ts

@@ -23,7 +23,6 @@ import {
   RepoPullRequests,
   RepositoryState,
 } from './repository.state';
-import { Issue } from 'src/app/repository/services/repository.interfaces';
 
 @Injectable()
 export class RepositoryEffects {
@@ -66,7 +65,6 @@ export class RepositoryEffects {
           repoLabels$,
         ).pipe(
           map(([info, prList, contents, readme, milestones, labels]) => {
-            console.log(info);
             const allData: RepositoryState = {
               description: info.description,
               forkCount: info.forks_count,
@@ -160,7 +158,6 @@ export class RepositoryEffects {
           .getRepositoryIssues(owner, repoName, params)
           .pipe(
             map((issues) => {
-              console.log(issues, params);
               return fetchIssuesSuccess({ issues, params });
             }),
             catchError((error) => of(fetchIssuesFailure({ error }))),

angular-ngrx-scss/src/app/state/repository/repository.state.ts

@@ -1,6 +1,5 @@
 import { Issue } from 'src/app/repository/services/repository.interfaces';
 import { UserApiResponse } from '../user';
-import { number } from '@primer/octicons';
 
 export interface RepositoryState {
   description: string;

angular-ngrx-scss/tsconfig.json

@@ -20,7 +20,6 @@
     "resolveJsonModule": true,
     "paths": {
       "@prism": [
-        "dist/prism/prism",
         "dist/prism"
       ]
     },