Revert "Add warning when index variable is implicitly retained"

This reverts commit 2ff1e36.

Author: mitchelloharawild

NEWS.md

@@ -3,7 +3,6 @@
 * Fixed `scan_gaps()` failing with data containing the `int` column name.
 * Removed `as_tibble.grouped_df()` to prevent masking `dplyr::as_tibble.grouped_df()`.
 * Added `summary()` method for time classes, allowing `summary()` to be called on tsibble objects. (#319)
-* `select()` and `transmute()` now warn when the index variable is dropped and automatically re-added.
 * `tsibble()` now builds columns sequentially, allowing columns to refer to previously created columns in the call. (#289)
 * Add tidyselect helpers for `index_var()`, `key_vars()` and `measured_vars()`. (#314)
 * Documentation improvements.

R/update.R

@@ -81,16 +81,6 @@ bind_tsibble <- function(data, template, position = c("before", "after")) {
     template <- remove_key(template, setdiff(key_vars(template), key_vars))
   }
   tsbl_vars <- setdiff(c(index_var(template), key_vars(template)), data_cols)
-  
-  # Warn if index variable was dropped
-  idx_var <- index_var(template)
-  if (idx_var %in% tsbl_vars) {
-    warn(sprintf(
-      "Index variable `%s` was dropped but has been automatically re-added.\nUse `as_tibble()` first if you want to remove the index.",
-      idx_var
-    ))
-  }
-  
   if (position == "before") {
     res <- bind_cols(as_tibble(template)[tsbl_vars], data)
   } else {

tests/testthat/test-dplyr.R

@@ -149,7 +149,7 @@ test_that("filter() and slice() with .preserve = TRUE", {
 })
 
 test_that("select() and rename()", {
-  expect_s3_class(select(tourism, Quarter, Region:Purpose), "tbl_ts")
+  expect_s3_class(select(tourism, Region:Purpose), "tbl_ts")
   expect_s3_class(select(tourism, Quarter:Purpose), "tbl_ts")
   expect_equal(
     quo_name(index(select(tourism, Index = Quarter, Region:Purpose))),
@@ -166,7 +166,7 @@ test_that("select() and rename()", {
   expect_named(select(tourism_mel, -Region), cols[-2])
   expect_named(select(tourism_mel, -State), cols[-3])
   expect_named(select(tourism_mel, -Purpose), cols[-4])
-  expect_named(select(tourism_mel, Quarter, Trips), c("Quarter", "Trips"))
+  expect_named(select(tourism_mel, Trips), c("Trips", "Quarter"))
   expect_named(select(tourism_mel, -Region, -State, -Purpose), cols[c(1, 5)])
 })
 
@@ -254,21 +254,21 @@ tsbl <- tsibble(
 )
 
 test_that("transmute()", {
-  out <- tourism %>% transmute(Quarter, Region = paste(Region, State))
+  out <- tourism %>% transmute(Region = paste(Region, State))
   expect_equal(ncol(out), 4)
-  trans_tsbl <- tsbl %>% transmute(qtr, group, z = a / b)
+  trans_tsbl <- tsbl %>% transmute(z = a / b)
   expect_equal(colnames(trans_tsbl), c("qtr", "group", "z"))
 })
 
 test_that("transmute.grouped_ts()", {
   out <- pedestrian %>%
     group_by(Time) %>%
-    transmute(Date_Time)
+    transmute()
   expect_equal(ncol(out), 3)
   out2 <- pedestrian %>%
     group_by_key() %>%
-    transmute(Date_Time)
-  expect_named(out2, c("Sensor", "Date_Time"))
+    transmute()
+  expect_named(out2, c("Date_Time", "Sensor"))
 })
 
 test_that("distinct()", {
@@ -355,33 +355,6 @@ test_that("rename() for renaming key", {
     rename("purpose" = "Purpose", "region" = "Region", "trip" = "Trips")
 })
 
-test_that("warning when index is automatically re-added #308", {
-  test_ts <- tsibble(
-    date = as.Date('2024-01-01') + 0:2,
-    value = 1:3
-  )
-  
-  # select() without index should warn
-  expect_warning(
-    result <- select(test_ts, value),
-    "Index variable `date` was dropped"
-  )
-  expect_true("date" %in% names(result))
-  
-  # transmute() without index should warn
-  expect_warning(
-    result2 <- transmute(test_ts, value2 = value * 2),
-    "Index variable `date` was dropped"
-  )
-  expect_true("date" %in% names(result2))
-  
-  # select() with index should not warn
-  expect_no_warning(
-    result3 <- select(test_ts, date, value)
-  )
-  expect_equal(names(result3), c("date", "value"))
-})
-
 test_that("drop redundant key #196", {
   sim_tourism <- tourism %>%
     filter(Purpose == "Holiday") %>%

tests/testthat/test-empty.R

@@ -13,7 +13,7 @@ test_that("dplyr verbs for empty tsibble", {
   expect_equal(NROW(ped_null), 0L)
   expect_s3_class(ped_null %>% group_by(Sensor), "grouped_ts")
   expect_equal(NROW(ped_null %>% mutate(Count1 = Count + 1)), 0L)
-  expect_equal(NROW(ped_null %>% transmute(Date_Time, Count1 = Count + 1)), 0L)
+  expect_equal(NROW(ped_null %>% transmute(Count1 = Count + 1)), 0L)
   expect_equal(NROW(ped_null %>% summarise(Count1 = sum(Count))), 0L)
   expect_identical(ped_null %>% arrange(Count), ped_null)
   expect_identical(ped_null %>% slice(0), ped_null)