Skip to content

Add null checks and improve Javadoc in Strops#137

Open
alexstaicu35 wants to merge 1 commit into
mainfrom
strops-null-input-validation
Open

Add null checks and improve Javadoc in Strops#137
alexstaicu35 wants to merge 1 commit into
mainfrom
strops-null-input-validation

Conversation

@alexstaicu35
Copy link
Copy Markdown

Summary

Harden Strops against null inputs and clarify its Javadoc so callers understand the contract.

Changes

  • Throw IllegalArgumentException from reverse and isPalindrome when input is null
  • Update Javadoc to document the null contract and the empty-string behaviour of isPalindrome
  • Minor punctuation fixes in method descriptions

Notes

This introduces a behavioural change: previously a null argument would surface as a NullPointerException. Callers now receive an IllegalArgumentException with a descriptive message.


changeset_id: 488cfdbd-a504-4565-b43e-b5fd717b3bb4

Trigger Artemis Fix Agent to iterate on comments left on your PR

  1. Wait until your reviewers are done leaving comments on the PR.
  2. Tag @artemis-fix-agent in a new comment — this will be your trigger comment. Optionally, add further instructions you want Artemis to act on.

Example trigger comment:

@artemis-fix-agent address all the review feedback above.

Artemis will pick up all existing PR comments automatically. Note that each time you tag @artemis-fix-agent, a separate, parallel fix attempt will be kicked off, so only tag Artemis once you're ready to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants