Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

indentation is not actually 2 spaces #49

Description

@vicapow

When you clone a project that uses uber-standard and run the linter, it complains that indentation should be 4, not 2. see: visgl/react-map-gl#41

Looks like this is only working now because most uber engineers have an .editorconfig setup to be something, more or less like this.

# EditorConfig: http://editorconfig.org

root = true

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

This should probably be as simple as changing: https://github.com/uber/standard/blob/master/rc/.eslintrc.json#L228 to be something like: https://github.com/feross/eslint-config-standard/blob/master/eslintrc.json#L38

I think copying that entire indent value might also fix: #46

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions